Merging in 2.0.2.

userland/Makefile

@@ -12,7 +12,6 @@ INCLUDES=\
 	include include \
 	include/sys include/sys \
 	include/test include/test \
-	include/test161 include/test161 \
 	include/types include/types
 
 INCLUDELINKS=\

userland/include/stdio.h

@@ -56,11 +56,6 @@ int vprintf(const char *fmt, __va_list ap);
 int snprintf(char *buf, size_t len, const char *fmt, ...);
 int vsnprintf(char *buf, size_t len, const char *fmt, __va_list ap);
 
-/* Automated testing extensions. */
-
-int tprintf(const char *fmt, ...);
-int nprintf(const char *fmt, ...);
-
 /* Print the argument string and then a newline. Returns 0 or -1 on error. */
 int puts(const char *);
 

userland/lib/Makefile

@@ -8,6 +8,6 @@
 TOP=../..
 .include "$(TOP)/mk/os161.config.mk"
 
-SUBDIRS=crt0 libc libtest libtest161 hostcompat
+SUBDIRS=crt0 libc libtest hostcompat
 
 .include "$(TOP)/mk/os161.subdir.mk"

userland/lib/hostcompat/Makefile

@@ -22,11 +22,6 @@ TOP=../../..
 LIB=hostcompat
 SRCS=err.c ntohll.c time.c hostcompat.c
 
-# printf
-COMMON=$(TOP)/common/libc
-SRCS+=\
-	$(COMMON)/printf/tprintf.c
-
 HOST_CFLAGS+=$(COMPAT_CFLAGS)
 
 MKDIRS=$(INSTALLTOP)/hostinclude

userland/lib/hostcompat/hostcompat.h

@@ -35,11 +35,6 @@ void hostcompat_init(int argc, char **argv);
 
 time_t __time(time_t *secs, unsigned long *nsecs);
 
-/* Automated testing extensions. */
-
-int tprintf(const char *fmt, ...);
-int nprintf(const char *fmt, ...);
-
 #ifdef DECLARE_NTOHLL
 uint64_t ntohll(uint64_t);
 #define htonll(x) (ntohll(x))

userland/lib/libc/Makefile

@@ -10,8 +10,7 @@ COMMON=$(TOP)/common/libc
 # printf
 SRCS+=\
 	$(COMMON)/printf/__printf.c \
-	$(COMMON)/printf/snprintf.c \
-	$(COMMON)/printf/tprintf.c
+	$(COMMON)/printf/snprintf.c
 
 # stdio
 SRCS+=\

userland/lib/libc/stdio/printf.c

@@ -31,8 +31,6 @@
 #include <stdarg.h>
 #include <unistd.h>
 #include <errno.h>
-#include <string.h>
-#include <kern/secret.h>
 
 /*
  * printf - C standard I/O function.

userland/lib/libc/unix/err.c

@@ -139,7 +139,6 @@ verr(int exitcode, const char *fmt, va_list ap)
 {
 	__printerr(1, fmt, ap);
 	exit(exitcode);
-	// exit() didn't work.
 }
 
 /* errx/verrx: don't use errno, but do then exit */
@@ -148,7 +147,6 @@ verrx(int exitcode, const char *fmt, va_list ap)
 {
 	__printerr(0, fmt, ap);
 	exit(exitcode);
-	// exit() didn't work.
 }
 
 /*

userland/testbin/Makefile

@@ -7,12 +7,11 @@ TOP=../..
 
 SUBDIRS=add argtest badcall bigexec bigfile bigfork bigseek bloat conman \
 	crash ctest dirconc dirseek dirtest f_test factorial farm faulter \
-	filetest fileonlytest forkbomb forktest frack guzzle hash hog huge kitchen \
+	filetest forkbomb forktest frack guzzle hash hog huge kitchen \
 	malloctest matmult multiexec palin parallelvm poisondisk psort \
 	quinthuge quintmat quintsort randcall redirect rmdirtest rmtest \
-	sbrktest schedpong shll sink sort sparsefile spinner sty tail tictac \
-	triplehuge triplemat triplesort usemtest waiter zero \
-	consoletest shelltest opentest readwritetest closetest stacktest
+	sbrktest schedpong sink sort sparsefile sty tail tictac triplehuge \
+	triplemat triplesort usemtest zero
 
 # But not:
 #    userthreads    (no support in kernel API in base system)

userland/testbin/add/add.c

@@ -38,7 +38,6 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <err.h>
-#include <test161/test161.h>
 
 int
 main(int argc, char *argv[])
@@ -52,9 +51,7 @@ main(int argc, char *argv[])
 	i = atoi(argv[1]);
 	j = atoi(argv[2]);
 
-	tprintf("Answer: %d\n", i+j);
-	char buf[16];
-	snprintf(buf, 16, "%d", i+j);
-	secprintf(SECRET, buf, "/testbin/add");
+	printf("Answer: %d\n", i+j);
+
 	return 0;
 }

userland/testbin/argtest/argtest.c

@@ -36,7 +36,6 @@
  */
 
 #include <stdio.h>
-#include <test161/test161.h>
 
 int
 main(int argc, char *argv[])
@@ -44,18 +43,14 @@ main(int argc, char *argv[])
 	const char *tmp;
 	int i;
 
-	tprintf("argc: %d\n", argc);
-	char buf[16];
-	snprintf(buf, 16, "argc: %d", argc);
-	secprintf(SECRET, buf, "/testbin/argtest");
+	printf("argc: %d\n", argc);
 
 	for (i=0; i<=argc; i++) {
 		tmp = argv[i];
 		if (tmp==NULL) {
 			tmp = "[NULL]";
 		}
-		tprintf("argv[%d]: %s\n", i, tmp);
-		secprintf(SECRET, tmp, "/testbin/argtest");
+		printf("argv[%d]: %s\n", i, tmp);
 	}
 
 	return 0;

userland/testbin/badcall/bad_chdir.c

@@ -38,7 +38,7 @@
 #include "test.h"
 
 static
-int
+void
 chdir_empty(void)
 {
 	int rv;
@@ -49,20 +49,13 @@ chdir_empty(void)
 
 	report_begin("chdir to empty string");
 	rv = chdir("");
-	return report_check2(rv, errno, EINVAL, 0);
+	report_check2(rv, errno, EINVAL, 0);
 }
 
 void
 test_chdir(void)
 {
-	int ntests = 0, result = 0, lost_points = 0;
-	test_chdir_path(&ntests, &lost_points);
-
-	ntests++;
-	result = chdir_empty();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_chdir_path();
+	chdir_empty();
 }
 

userland/testbin/badcall/bad_close.c

@@ -36,9 +36,5 @@
 void
 test_close(void)
 {
-	int ntests = 0, lost_points = 0;
-	test_close_fd(&ntests, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_close_fd();
 }

userland/testbin/badcall/bad_dup2.c

@@ -45,29 +45,27 @@
 #include "test.h"
 
 static
-int
+void
 dup2_fd2(int fd, const char *desc)
 {
-	int rv, failure;
+	int rv;
 
 	report_begin("%s", desc);
 	rv = dup2(STDIN_FILENO, fd);
-	failure = report_check(rv, errno, EBADF);
+	report_check(rv, errno, EBADF);
 
 	if (rv != -1) {
 		close(fd);	/* just in case */
 	}
-	return failure;
 }
 
 static
-int
+void
 dup2_self(void)
 {
 	struct stat sb;
 	int rv;
 	int testfd;
-	int failure;
 
 	/* use fd that isn't in use */
 	testfd = CLOSED_FD;
@@ -77,23 +75,22 @@ dup2_self(void)
 	rv = dup2(STDIN_FILENO, testfd);
 	if (rv == -1) {
 		report_result(rv, errno);
-		report_aborted(&failure);
-		return failure;
+		report_aborted();
+		return;
 	}
 
 	report_begin("dup2 to same fd");
 	rv = dup2(testfd, testfd);
 	if (rv == testfd) {
-		report_passed(&failure);
+		report_passed();
 	}
 	else if (rv<0) {
 		report_result(rv, errno);
-		report_failure(&failure);
+		report_failure();
 	}
 	else {
 		report_warnx("returned %d instead", rv);
-		report_failure(&failure);
-		failure = FAILED;
+		report_failure();
 	}
 
 	report_begin("fstat fd after dup2 to itself");
@@ -103,60 +100,43 @@ dup2_self(void)
 	}
 	report_result(rv, errno);
 	if (rv==0) {
-		report_passed(&failure);
+		report_passed();
 	}
 	else if (errno != ENOSYS) {
-		report_failure(&failure);
+		report_failure();
 	}
 	else {
-		report_skipped(&failure);
+		report_skipped();
 		/* no support for fstat; try lseek */
 		report_begin("lseek fd after dup2 to itself");
 		rv = lseek(testfd, 0, SEEK_CUR);
 		report_result(rv, errno);
 		if (rv==0 || (rv==-1 && errno==ESPIPE)) {
-			report_passed(&failure);
+			report_passed();
 		}
 		else {
-			report_failure(&failure);
+			report_failure();
 		}
 	}
 
 	close(testfd);
-	return failure;
 }
 
 void
 test_dup2(void)
 {
-	int ntests = 0, failure, lost_points = 0;
 	/* This does the first fd. */
-	test_dup2_fd(&ntests, &lost_points);
+	test_dup2_fd();
 
 	/* Any interesting cases added here should also go in common_fds.c */
-	ntests++;
-	failure = dup2_fd2(-1, "dup2 to -1");
-	handle_result(failure, &lost_points);
-
-	ntests++;
-	failure = dup2_fd2(-5, "dup2 to -5");
-	handle_result(failure, &lost_points);
-
-	ntests++;
-	failure = dup2_fd2(IMPOSSIBLE_FD, "dup2 to impossible fd");
-	handle_result(failure, &lost_points);
+	dup2_fd2(-1, "dup2 to -1");
+	dup2_fd2(-5, "dup2 to -5");
+	dup2_fd2(IMPOSSIBLE_FD, "dup2 to impossible fd");
 #ifdef OPEN_MAX
-	ntests++;
-	failure = dup2_fd2(OPEN_MAX, "dup2 to OPEN_MAX");
-	handle_result(failure, &lost_points);
+	dup2_fd2(OPEN_MAX, "dup2 to OPEN_MAX");
 #else
 	warnx("Warning: OPEN_MAX not defined - test skipped");
 #endif
 
-	ntests++;
-	failure = dup2_self();
-	handle_result(failure, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	dup2_self();
 }

userland/testbin/badcall/bad_execv.c

@@ -32,7 +32,6 @@
  */
 
 #include <sys/types.h>
-#include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include <errno.h>
@@ -43,7 +42,7 @@
 
 static
 int
-exec_common_fork(int *result)
+exec_common_fork(void)
 {
 	int pid, rv, status, err;
 
@@ -57,7 +56,7 @@ exec_common_fork(int *result)
 		err = errno;
 		report_begin("forking for test");
 		report_result(pid, err);
-		report_aborted(result);
+		report_aborted();
 		return -1;
 	}
 
@@ -71,11 +70,10 @@ exec_common_fork(int *result)
 		err = errno;
 		report_begin("waiting for test subprocess");
 		report_result(rv, err);
-		report_failure(result);
+		report_failure();
 		return -1;
 	}
 	if (WIFEXITED(status) && WEXITSTATUS(status) == MAGIC_STATUS) {
-		*result = SUCCESS;
 		return 1;
 	}
 	/* Oops... */
@@ -86,134 +84,98 @@ exec_common_fork(int *result)
 	else {
 		report_warnx("exit %d", WEXITSTATUS(status));
 	}
-	report_failure(result);
+	report_failure();
 	return -1;
 }
 
 static
-int
+void
 exec_badprog(const void *prog, const char *desc)
 {
 	int rv;
-	int result;
 	char *args[2];
 	args[0] = (char *)"foo";
 	args[1] = NULL;
 
-	if (exec_common_fork(&result) != 0) {
-		return result;
+	if (exec_common_fork() != 0) {
+		return;
 	}
 
 	report_begin(desc);
 	rv = execv(prog, args);
-	result = report_check(rv, errno, EFAULT);
-	int code = result ? result : MAGIC_STATUS;
-	exit(code);
+	report_check(rv, errno, EFAULT);
+	exit(MAGIC_STATUS);
 }
 
 static
-int
+void
 exec_emptyprog(void)
 {
 	int rv;
-	int result;
 	char *args[2];
 	args[0] = (char *)"foo";
 	args[1] = NULL;
 
-	if (exec_common_fork(&result) != 0) {
-		return result;
+	if (exec_common_fork() != 0) {
+		return;
 	}
 
 	report_begin("exec the empty string");
 	rv = execv("", args);
-	result = report_check2(rv, errno, EINVAL, EISDIR);
-	int code = result ? result : MAGIC_STATUS;
-	exit(code);
+	report_check2(rv, errno, EINVAL, EISDIR);
+	exit(MAGIC_STATUS);
 }
 
 static
-int
+void
 exec_badargs(void *args, const char *desc)
 {
 	int rv;
-	int result;
-	if (exec_common_fork(&result) != 0) {
-		return result;
+
+	if (exec_common_fork() != 0) {
+		return;
 	}
 
 	report_begin(desc);
 	rv = execv("/bin/true", args);
-	result = report_check(rv, errno, EFAULT);
-	int code = result ? result : MAGIC_STATUS;
-	exit(code);
+	report_check(rv, errno, EFAULT);
+	exit(MAGIC_STATUS);
 }
 
 static
-int
+void
 exec_onearg(void *ptr, const char *desc)
 {
 	int rv;
-	int result;
 
 	char *args[3];
 	args[0] = (char *)"foo";
 	args[1] = (char *)ptr;
 	args[2] = NULL;
 
-	if (exec_common_fork(&result) != 0) {
-		return result;
+	if (exec_common_fork() != 0) {
+		return;
 	}
 
 	report_begin(desc);
 	rv = execv("/bin/true", args);
-	result = report_check(rv, errno, EFAULT);
-	int code = result ? result : MAGIC_STATUS;
-	exit(code);
-
+	report_check(rv, errno, EFAULT);
+	exit(MAGIC_STATUS);
 }
 
 void
 test_execv(void)
 {
-	int ntests = 0, result = 0, lost_points = 0;
-	ntests++;
-	result = exec_badprog(NULL, "exec with NULL program");
-	handle_result(result, &lost_points);
+	exec_badprog(NULL, "exec with NULL program");
+	exec_badprog(INVAL_PTR, "exec with invalid pointer program");
+	exec_badprog(KERN_PTR, "exec with kernel pointer program");
 
-	ntests++;
-	result = exec_badprog(INVAL_PTR, "exec with invalid pointer program");
-	handle_result(result, &lost_points);
+	exec_emptyprog();
 
-	ntests++;
-	result = exec_badprog(KERN_PTR, "exec with kernel pointer program");
-	handle_result(result, &lost_points);
+	exec_badargs(NULL, "exec with NULL arglist");
+	exec_badargs(INVAL_PTR, "exec with invalid pointer arglist");
+	exec_badargs(KERN_PTR, "exec with kernel pointer arglist");
 
-	ntests++;
-	result = exec_emptyprog();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = exec_badargs(NULL, "exec with NULL arglist");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = exec_badargs(INVAL_PTR, "exec with invalid pointer arglist");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = exec_badargs(KERN_PTR, "exec with kernel pointer arglist");
-	handle_result(result, &lost_points);
-
-
-	ntests++;
-	result = exec_onearg(INVAL_PTR, "exec with invalid pointer arg");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = exec_onearg(KERN_PTR, "exec with kernel pointer arg");
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	exec_onearg(INVAL_PTR, "exec with invalid pointer arg");
+	exec_onearg(KERN_PTR, "exec with kernel pointer arg");
 }

userland/testbin/badcall/bad_fsync.c

@@ -36,11 +36,6 @@
 void
 test_fsync(void)
 {
-	int ntests = 0, lost_points = 0;
-
-	test_fsync_fd(&ntests, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_fsync_fd();
 }
 

userland/testbin/badcall/bad_ftruncate.c

@@ -44,67 +44,52 @@
 #include "test.h"
 
 static
-int
+void
 ftruncate_fd_device(void)
 {
 	int rv, fd;
-	int result;
 
 	report_begin("ftruncate on device");
 
 	fd = open("null:", O_RDWR);
 	if (fd<0) {
 		report_warn("opening null: failed");
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 
 	rv = ftruncate(fd, 6);
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 
 	close(fd);
-	return result;
 }
 
 static
-int
+void
 ftruncate_size_neg(void)
 {
 	int rv, fd;
-	int result;
 
 	report_begin("ftruncate to negative size");
 
 	fd = open_testfile(NULL);
 	if (fd<0) {
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 
 	rv = ftruncate(fd, -60);
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 
 	close(fd);
 	remove(TESTFILE);
-	return result;
 }
 
 void
 test_ftruncate(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	test_ftruncate_fd();
 
-	test_ftruncate_fd(&ntests, &lost_points);
-
-	ntests++;
-	result = ftruncate_fd_device();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = ftruncate_size_neg();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	ftruncate_fd_device();
+	ftruncate_size_neg();
 }

userland/testbin/badcall/bad_getcwd.c

@@ -36,9 +36,5 @@
 void
 test_getcwd(void)
 {
-	int ntests = 0, lost_points = 0;
-	test_getcwd_buf(&ntests, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_getcwd_buf();
 }

userland/testbin/badcall/bad_getdirentry.c

@@ -36,11 +36,6 @@
 void
 test_getdirentry(void)
 {
-	int ntests = 0, lost_points = 0;
-
-	test_getdirentry_fd(&ntests, &lost_points);
-	test_getdirentry_buf(&ntests, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_getdirentry_fd();
+	test_getdirentry_buf();
 }

userland/testbin/badcall/bad_ioctl.c

@@ -41,34 +41,30 @@
 #include "test.h"
 
 static
-int
+void
 one_ioctl_badbuf(int fd, int code, const char *codename,
 		 void *ptr, const char *ptrdesc)
 {
 	int rv;
-	int result;
 
 	report_begin("ioctl %s with %s", codename, ptrdesc);
 	rv = ioctl(fd, code, ptr);
-	result = report_check(rv, errno, EFAULT);
-	return result;
+	report_check(rv, errno, EFAULT);
 }
 
 static
-int
+void
 any_ioctl_badbuf(int fd, int code, const char *codename)
 {
-	int result;
-	result = one_ioctl_badbuf(fd, code, codename, NULL, "NULL pointer");
-	result |= one_ioctl_badbuf(fd, code, codename, INVAL_PTR, "invalid pointer");
-	result |= one_ioctl_badbuf(fd, code, codename, KERN_PTR, "kernel pointer");
-	return result;
+	one_ioctl_badbuf(fd, code, codename, NULL, "NULL pointer");
+	one_ioctl_badbuf(fd, code, codename, INVAL_PTR, "invalid pointer");
+	one_ioctl_badbuf(fd, code, codename, KERN_PTR, "kernel pointer");
 }
 
 #define IOCTL(fd, sym) any_ioctl_badbuf(fd, sym, #sym)
 
 static
-int
+void
 ioctl_badbuf(void)
 {
 	/*
@@ -83,39 +79,25 @@ ioctl_badbuf(void)
 
 	/* suppress gcc warning */
 	(void)any_ioctl_badbuf;
-	return 0;
 }
 
 static
-int
+void
 ioctl_badcode(void)
 {
 	int rv;
-	int result;
 
 	report_begin("invalid ioctl");
 	rv = ioctl(STDIN_FILENO, NONEXIST_IOCTL, NULL);
-	result = report_check(rv, errno, EIOCTL);
-	return result;
+	report_check(rv, errno, EIOCTL);
 }
 
 void
 test_ioctl(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
-
-	test_ioctl_fd(&ntests, &lost_points);
+	test_ioctl_fd();
 
 	/* Since we don't actually define any ioctls, this is not meaningful */
-	ntests++;
-	result = ioctl_badcode();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = ioctl_badbuf();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	ioctl_badcode();
+	ioctl_badbuf();
 }

userland/testbin/badcall/bad_link.c

@@ -37,70 +37,52 @@
 #include "test.h"
 
 static
-int
+void
 link_dir(void)
 {
 	int rv;
-	int result;
 
 	report_begin("hard link of .");
 	rv = link(".", TESTDIR);
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 	if (rv==0) {
 		/* this might help recover... maybe */
 		remove(TESTDIR);
 	}
-	return result;
 }
 
 static
-int
+void
 link_empty1(void)
 {
 	int rv;
 
 	report_begin("hard link of empty string");
 	rv = link("", TESTDIR);
-	return report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 }
 
 static
-int
+void
 link_empty2(void)
 {
 	int rv;
-	int result = FAILED;
+
 	report_begin("hard link to empty string");
 	if (create_testdir()<0) {
 		/*report_aborted();*/ /* XXX in create_testdir */
-		return result;
+		return;
 	}
 	rv = link(TESTDIR, "");
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 	rmdir(TESTDIR);
-	return result;
 }
 
 void
 test_link(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
-
-	test_link_paths(&ntests, &lost_points);
-
-	ntests++;
-	result = link_dir();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = link_empty1();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = link_empty2();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_link_paths();
+	link_dir();
+	link_empty1();
+	link_empty2();
 }

userland/testbin/badcall/bad_lseek.c

@@ -44,38 +44,34 @@
 #include "test.h"
 
 static
-int
+void
 lseek_fd_device(void)
 {
 	int fd, rv;
-	int result;
 
 	report_begin("lseek on device");
 
 	fd = open("null:", O_RDONLY);
 	if (fd<0) {
 		report_warn("opening null: failed");
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 
 	rv = lseek(fd, 309, SEEK_SET);
-	result = report_check(rv, errno, ESPIPE);
+	report_check(rv, errno, ESPIPE);
 
 	close(fd);
-
-	return result;
 }
 
 static
-int
+void
 lseek_file_stdin(void)
 {
 	int fd, fd2, rv, status;
 	const char slogan[] = "There ain't no such thing as a free lunch";
 	size_t len = strlen(slogan);
 	pid_t pid;
-	int result = 0;
 
 	report_begin("lseek stdin when open on file");
 
@@ -83,27 +79,27 @@ lseek_file_stdin(void)
 	pid = fork();
 	if (pid<0) {
 		report_warn("fork failed");
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 	else if (pid!=0) {
 		/* parent */
 		rv = waitpid(pid, &status, 0);
 		if (rv<0) {
 			report_warn("waitpid failed");
-			report_aborted(&result);
+			report_aborted();
 		}
 		if (WIFSIGNALED(status)) {
 			report_warnx("subprocess exited with signal %d",
 				     WTERMSIG(status));
-			report_aborted(&result);
+			report_aborted();
 		}
 		else if (WIFEXITED(status) && WEXITSTATUS(status) != 0) {
 			report_warnx("subprocess exited with code %d",
 				     WEXITSTATUS(status));
-			report_aborted(&result);
+			report_aborted();
 		}
-		return result;
+		return;
 	}
 
 	/* child */
@@ -150,159 +146,133 @@ lseek_file_stdin(void)
 	}
 
 	/* blah */
-	report_skipped(&result);
+	report_skipped();
 
 	rv = lseek(STDIN_FILENO, 0, SEEK_SET);
 	report_begin("try 1: SEEK_SET");
-	result = report_check(rv, errno, 0);
+	report_check(rv, errno, 0);
 
 	rv = lseek(STDIN_FILENO, 0, SEEK_END);
 	report_begin("try 2: SEEK_END");
-	result = report_check(rv, errno, 0);
+	report_check(rv, errno, 0);
 
 	remove(TESTFILE);
 	_exit(0);
 }
 
 static
-int
+void
 lseek_loc_negative(void)
 {
 	int fd, rv;
-	int result;
 
 	report_begin("lseek to negative offset");
 
 	fd = open_testfile(NULL);
 	if (fd<0) {
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 
 	rv = lseek(fd, -309, SEEK_SET);
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 
 	close(fd);
 	remove(TESTFILE);
-
-	return result;
 }
 
 static
-int
+void
 lseek_whence_inval(void)
 {
 	int fd, rv;
-	int result;
 
 	report_begin("lseek with invalid whence code");
 
 	fd = open_testfile(NULL);
 	if (fd<0) {
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 
 	rv = lseek(fd, 0, 3594);
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 
 	close(fd);
 	remove(TESTFILE);
-	return result;
 }
 
 static
-int
+void
 lseek_loc_pasteof(void)
 {
 	const char *message = "blahblah";
 	int fd;
 	off_t pos;
-	int result;
 
 	report_begin("seek past/to EOF");
 
 	fd = open_testfile(message);
 	if (fd<0) {
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 
 	pos = lseek(fd, 5340, SEEK_SET);
 	if (pos == -1) {
 		report_warn("lseek past EOF failed");
-		report_failure(&result);
+		report_failure();
 		goto out;
 	}
 	if (pos != 5340) {
 		report_warnx("lseek to 5340 got offset %lld", (long long) pos);
-		report_failure(&result);
+		report_failure();
 		goto out;
 	}
 
 	pos = lseek(fd, -50, SEEK_CUR);
 	if (pos == -1) {
 		report_warn("small seek beyond EOF failed");
-		report_failure(&result);
+		report_failure();
 		goto out;
 	}
 	if (pos != 5290) {
 		report_warnx("SEEK_CUR to 5290 got offset %lld",
 			     (long long) pos);
-		report_failure(&result);
+		report_failure();
 		goto out;
 	}
 
 	pos = lseek(fd, 0, SEEK_END);
 	if (pos == -1) {
 		report_warn("seek to EOF failed");
-		report_failure(&result);
+		report_failure();
 		goto out;
 	}
 
 	if (pos != (off_t) strlen(message)) {
 		report_warnx("seek to EOF got %lld (should be %zu)",
 			     (long long) pos, strlen(message));
-		report_failure(&result);
+		report_failure();
 		goto out;
 	}
 
-	report_passed(&result);
+	report_passed();
 
     out:
 	close(fd);
 	remove(TESTFILE);
-	return result;
+	return;
 }
 
 void
 test_lseek(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	test_lseek_fd();
 
-	test_lseek_fd(&ntests, &lost_points);
-
-	ntests++;
-	result = lseek_fd_device();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = lseek_file_stdin();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = lseek_loc_negative();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = lseek_loc_pasteof();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = lseek_whence_inval();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	lseek_fd_device();
+	lseek_file_stdin();
+	lseek_loc_negative();
+	lseek_loc_pasteof();
+	lseek_whence_inval();
 }

userland/testbin/badcall/bad_mkdir.c

@@ -44,58 +44,44 @@
 #include "test.h"
 
 static
-int
+void
 mkdir_dot(void)
 {
 	int rv;
 
 	report_begin("mkdir .");
 	rv = mkdir(".", 0775);
-	return report_check(rv, errno, EEXIST);
+	report_check(rv, errno, EEXIST);
 }
 
 static
-int
+void
 mkdir_dotdot(void)
 {
 	int rv;
 
 	report_begin("mkdir ..");
 	rv = mkdir("..", 0775);
-	return report_check(rv, errno, EEXIST);
+	report_check(rv, errno, EEXIST);
 }
 
 static
-int
+void
 mkdir_empty(void)
 {
 	int rv;
 
 	report_begin("mkdir of empty string");
 	rv = mkdir("", 0775);
-	return report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 }
 
 void
 test_mkdir(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	test_mkdir_path();
 
-	test_mkdir_path(&ntests, &lost_points);
-
-	ntests++;
-	result = mkdir_dot();
-	handle_result(result, &lost_points);
-
-	ntests++;
+	mkdir_dot();
 	mkdir_dotdot();
-	handle_result(result, &lost_points);
-
-	ntests++;
 	mkdir_empty();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
 }

userland/testbin/badcall/bad_open.c

@@ -44,48 +44,35 @@
 #include "test.h"
 
 static
-int
+void
 open_badflags(void)
 {
 	int fd;
 
 	report_begin("open null: with bad flags");
 	fd = open("null:", 309842);
-	return report_check(fd, errno, EINVAL);
+	report_check(fd, errno, EINVAL);
 }
 
 static
-int
+void
 open_empty(void)
 {
 	int rv;
-	int result;
 
 	report_begin("open empty string");
 	rv = open("", O_RDONLY);
-	result = report_check2(rv, errno, 0, EINVAL);
+	report_check2(rv, errno, 0, EINVAL);
 	if (rv>=0) {
 		close(rv);
 	}
-	return result;
 }
 
 void
 test_open(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	test_open_path();
 
-	test_open_path(&ntests, &lost_points);
-
-	ntests++;
-	result = open_badflags();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = open_empty();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	open_badflags();
+	open_empty();
 }

userland/testbin/badcall/bad_pipe.c

@@ -44,23 +44,22 @@
 #include "test.h"
 
 static
-int
+void
 pipe_badptr(void *ptr, const char *desc)
 {
 	int rv;
 
 	report_begin("%s", desc);
 	rv = pipe(ptr);
-	return report_check(rv, errno, EFAULT);
+	report_check(rv, errno, EFAULT);
 }
 
 static
-int
+void
 pipe_unaligned(void)
 {
 	int fds[3], rv;
 	char *ptr;
-	int result;
 
 	report_begin("pipe with unaligned pointer");
 
@@ -68,32 +67,15 @@ pipe_unaligned(void)
 	ptr++;
 
 	rv = pipe((int *)ptr);
-	report_survival(rv, errno, &result);
-	return result;
+	report_survival(rv, errno);
 }
 
 void
 test_pipe(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	pipe_badptr(NULL, "pipe with NULL pointer");
+	pipe_badptr(INVAL_PTR, "pipe with invalid pointer");
+	pipe_badptr(KERN_PTR, "pipe with kernel pointer");
 
-	ntests++;
-	result = pipe_badptr(NULL, "pipe with NULL pointer");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = pipe_badptr(INVAL_PTR, "pipe with invalid pointer");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = pipe_badptr(KERN_PTR, "pipe with kernel pointer");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = pipe_unaligned();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	pipe_unaligned();
 }

userland/testbin/badcall/bad_read.c

@@ -36,13 +36,7 @@
 void
 test_read(void)
 {
-	int ntests = 0, lost_points = 0;
-
-	test_read_fd(&ntests, &lost_points);
-	test_read_buf(&ntests, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
-
+	test_read_fd();
+	test_read_buf();
 }
 

userland/testbin/badcall/bad_readlink.c

@@ -37,28 +37,26 @@
 #include "test.h"
 
 static
-int
+void
 readlink_file(void)
 {
 	char buf[128];
 	int fd, rv;
-	int result;
 
 	report_begin("readlink on file");
 	fd = open_testfile("the question contains an invalid assumption");
 	if (fd<0) {
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 	close(fd);
 	rv = readlink(TESTFILE, buf, sizeof(buf));
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 	remove(TESTFILE);
-	return result;
 }
 
 static
-int
+void
 readlink_dir(void)
 {
 	char buf[128];
@@ -66,11 +64,11 @@ readlink_dir(void)
 
 	report_begin("readlink on .");
 	rv = readlink(".", buf, sizeof(buf));
-	return report_check(rv, errno, EISDIR);
+	report_check(rv, errno, EISDIR);
 }
 
 static
-int
+void
 readlink_empty(void)
 {
 	char buf[128];
@@ -78,31 +76,17 @@ readlink_empty(void)
 
 	report_begin("readlink on empty string");
 	rv = readlink("", buf, sizeof(buf));
-	return report_check2(rv, errno, EISDIR, EINVAL);
+	report_check2(rv, errno, EISDIR, EINVAL);
 }
 
 void
 test_readlink(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	test_readlink_path();
+	test_readlink_buf();
 
-	test_readlink_path(&ntests, &lost_points);
-	test_readlink_buf(&ntests, &lost_points);
-
-	ntests++;
-	result = readlink_file();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = readlink_dir();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = readlink_empty();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	readlink_file();
+	readlink_dir();
+	readlink_empty();
 }
 

userland/testbin/badcall/bad_reboot.c

@@ -44,27 +44,19 @@
 #include "test.h"
 
 static
-int
+void
 reboot_badflags(void)
 {
 	int rv;
 
-	tprintf("(This should not kill the system...)\n");
+	printf("(This should not kill the system...)\n");
 	report_begin("reboot with invalid flags");
 	rv = reboot(15353);
-	return report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 }
 
 void
 test_reboot(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
-
-	ntests++;
-	result = reboot_badflags();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	reboot_badflags();
 }

userland/testbin/badcall/bad_remove.c

@@ -44,83 +44,63 @@
 #include "test.h"
 
 static
-int
+void
 remove_dir(void)
 {
 	int rv;
-	int result = FAILED;
 
 	report_begin("remove() on a directory");
 
 	if (create_testdir() < 0) {
 		/*report_aborted();*/ /* XXX in create_testdir */
-		return result;
+		return;
 	}
 
 	rv = remove(TESTDIR);
-	result = report_check(rv, errno, EISDIR);
+	report_check(rv, errno, EISDIR);
 	rmdir(TESTDIR);
-
-	return result;
 }
 
 static
-int
+void
 remove_dot(void)
 {
 	int rv;
 
 	report_begin("remove() on .");
 	rv = remove(".");
-	return report_check2(rv, errno, EISDIR, EINVAL);
+	report_check2(rv, errno, EISDIR, EINVAL);
 }
 
 static
-int
+void
 remove_dotdot(void)
 {
 	int rv;
 
 	report_begin("remove() on ..");
 	rv = remove("..");
-	return report_check2(rv, errno, EISDIR, EINVAL);
+	report_check2(rv, errno, EISDIR, EINVAL);
 }
 
 static
-int
+void
 remove_empty(void)
 {
 	int rv;
 
 	report_begin("remove() on empty string");
 	rv = remove("");
-	return report_check2(rv, errno, EISDIR, EINVAL);
+	report_check2(rv, errno, EISDIR, EINVAL);
 }
 
 void
 test_remove(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	test_remove_path();
 
-	test_remove_path(&ntests, &lost_points);
-
-	ntests++;
-	result = remove_dir();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = remove_dot();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = remove_dotdot();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = remove_empty();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	remove_dir();
+	remove_dot();
+	remove_dotdot();
+	remove_empty();
 }

userland/testbin/badcall/bad_rename.c

@@ -37,100 +37,75 @@
 #include "test.h"
 
 static
-int
+void
 rename_dot(void)
 {
 	int rv;
-	int result;
 
 	report_begin("rename .");
 
 	rv = rename(".", TESTDIR);
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 	if (rv==0) {
 		/* oops... put it back */
 		rename(TESTDIR, ".");
 	}
-	return result;
 }
 
 static
-int
+void
 rename_dotdot(void)
 {
 	int rv;
-	int result;
 
 	report_begin("rename ..");
 	rv = rename("..", TESTDIR);
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 	if (rv==0) {
 		/* oops... put it back */
 		rename(TESTDIR, "..");
 	}
-	return result;
 }
 
 static
-int
+void
 rename_empty1(void)
 {
 	int rv;
-	int result;
 
 	report_begin("rename empty string");
 	rv = rename("", TESTDIR);
-	result = report_check2(rv, errno, EISDIR, EINVAL);
+	report_check2(rv, errno, EISDIR, EINVAL);
 	if (rv==0) {
 		/* don't try to remove it */
 		rename(TESTDIR, TESTDIR "-foo");
 	}
-	return result;
 }
 
 static
-int
+void
 rename_empty2(void)
 {
 	int rv;
-	int result = FAILED;
 
 	report_begin("rename to empty string");
 	if (create_testdir()<0) {
 		/*report_aborted();*/ /* XXX in create_testdir */
-		return result;
+		return;
 	}
 	rv = rename(TESTDIR, "");
-	result = report_check2(rv, errno, EISDIR, EINVAL);
+	report_check2(rv, errno, EISDIR, EINVAL);
 	rmdir(TESTDIR);
-	return result;
 }
 
 void
 test_rename(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	test_rename_paths();
 
-	test_rename_paths(&ntests, &lost_points);
-
-	ntests++;
-	result = rename_dot();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = rename_dotdot();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = rename_empty1();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = rename_empty2();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	rename_dot();
+	rename_dotdot();
+	rename_empty1();
+	rename_empty2();
 }
 

userland/testbin/badcall/bad_rmdir.c

@@ -44,83 +44,61 @@
 #include "test.h"
 
 static
-int
+void
 rmdir_file(void)
 {
 	int rv;
-	int result;
 
 	report_begin("rmdir a file");
 	if (create_testfile()<0) {
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 	rv = rmdir(TESTFILE);
-	result = report_check(rv, errno, ENOTDIR);
+	report_check(rv, errno, ENOTDIR);
 	remove(TESTFILE);
-
-	return result;
 }
 
 static
-int
+void
 rmdir_dot(void)
 {
 	int rv;
-	int result;
 
 	report_begin("rmdir .");
 	rv = rmdir(".");
-	result = report_check(rv, errno, EINVAL);
-	return result;
+	report_check(rv, errno, EINVAL);
 }
 
 static
-int
+void
 rmdir_dotdot(void)
 {
 	int rv;
 
 	report_begin("rmdir ..");
 	rv = rmdir("..");
-	return report_check2(rv, errno, EINVAL, ENOTEMPTY);
+	report_check2(rv, errno, EINVAL, ENOTEMPTY);
 }
 
 static
-int
+void
 rmdir_empty(void)
 {
 	int rv;
 
 	report_begin("rmdir empty string");
 	rv = rmdir("");
-	return report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 }
 
 void
 test_rmdir(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	test_rmdir_path();
 
-	test_rmdir_path(&ntests, &lost_points);
-
-	ntests++;
-	result = rmdir_file();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = rmdir_dot();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = rmdir_dotdot();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = rmdir_empty();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	rmdir_file();
+	rmdir_dot();
+	rmdir_dotdot();
+	rmdir_empty();
 }

userland/testbin/badcall/bad_sbrk.c

@@ -59,7 +59,7 @@ try_sbrk(long val)
 }
 
 static
-int
+void
 enforce_sbrk(long val, const char *desc, int err)
 {
 	int result;
@@ -67,79 +67,59 @@ enforce_sbrk(long val, const char *desc, int err)
 	report_begin("sbrk %s", desc);
 
 	result = try_sbrk(val);
-	return report_check(result, errno, err);
+	report_check(result, errno, err);
 }
 
 static
-int
+void
 sbrk_bigpos(void)
 {
-	return enforce_sbrk(1024*1024*1024 + (1024*1024*1024 - 4096*17), "huge positive", ENOMEM);
+	enforce_sbrk(4096*1024*256, "huge positive", ENOMEM);
 }
 
 static
-int
+void
 sbrk_bigneg(void)
 {
-	return enforce_sbrk(-4096*1024*256, "huge negative", EINVAL);
+	enforce_sbrk(-4096*1024*256, "huge negative", EINVAL);
 }
 
 static
-int
+void
 sbrk_neg(void)
 {
-	return enforce_sbrk(-8192, "too-large negative", EINVAL);
+	enforce_sbrk(-8192, "too-large negative", EINVAL);
 }
 
 static
-int
+void
 sbrk_unalignedpos(void)
 {
 	int result;
 
 	report_begin("sbrk unaligned positive");
 	result = try_sbrk(17);
-	return report_check2(result, errno, 0, EINVAL);
+	report_check2(result, errno, 0, EINVAL);
 }
 
 static
-int
+void
 sbrk_unalignedneg(void)
 {
 	int result;
 
 	report_begin("sbrk unaligned negative");
 	result = try_sbrk(-17);
-	return report_check2(result, errno, 0, EINVAL);
+	report_check2(result, errno, 0, EINVAL);
 }
 
 void
 test_sbrk(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
-
-	ntests++;
-	result = sbrk_neg();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = sbrk_bigpos();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = sbrk_bigneg();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = sbrk_unalignedpos();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = sbrk_unalignedneg();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	sbrk_neg();
+	sbrk_bigpos();
+	sbrk_bigneg();
+	sbrk_unalignedpos();
+	sbrk_unalignedneg();
 }
 

userland/testbin/badcall/bad_stat.c

@@ -67,7 +67,7 @@ badbuf_stat(struct stat *sb)
 }
 
 static
-int
+void
 common_badbuf(int (*statfunc)(struct stat *), void *ptr,
 	      const char *call, const char *ptrdesc)
 {
@@ -75,24 +75,22 @@ common_badbuf(int (*statfunc)(struct stat *), void *ptr,
 
 	report_begin("%s with %s buf", call, ptrdesc);
 	rv = statfunc(ptr);
-	return report_check(rv, errno, EFAULT);
+	report_check(rv, errno, EFAULT);
 }
 
 static
-int
+void
 any_badbuf(int (*statfunc)(struct stat *), const char *call)
 {
-	int result;
-	result = common_badbuf(statfunc, NULL, call, "NULL");
-	result |= common_badbuf(statfunc, INVAL_PTR, call, "invalid pointer");
-	result |= common_badbuf(statfunc, KERN_PTR, call, "kernel pointer");
-	return result;
+	common_badbuf(statfunc, NULL, call, "NULL");
+	common_badbuf(statfunc, INVAL_PTR, call, "invalid pointer");
+	common_badbuf(statfunc, KERN_PTR, call, "kernel pointer");
 }
 
 ////////////////////////////////////////////////////////////
 
 static
-int
+void
 any_empty(int (*statfunc)(const char *, struct stat *), const char *call)
 {
 	struct stat sb;
@@ -100,7 +98,7 @@ any_empty(int (*statfunc)(const char *, struct stat *), const char *call)
 
 	report_begin("%s on empty string", call);
 	rv = statfunc("", &sb);
-	return report_check2(rv, errno, 0, EINVAL);
+	report_check2(rv, errno, 0, EINVAL);
 }
 
 ////////////////////////////////////////////////////////////
@@ -108,56 +106,23 @@ any_empty(int (*statfunc)(const char *, struct stat *), const char *call)
 void
 test_fstat(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
-
-	test_fstat_fd(&ntests, &lost_points);
-
-	ntests++;
-	result = any_badbuf(badbuf_fstat, "fstat");
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_fstat_fd();
+	any_badbuf(badbuf_fstat, "fstat");
 }
 
 void
 test_lstat(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
-
-	test_lstat_path(&ntests, &lost_points);
-
-	ntests++;
-	result = any_empty(lstat, "lstat");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = any_badbuf(badbuf_lstat, "lstat");
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_lstat_path();
+	any_empty(lstat, "lstat");
+	any_badbuf(badbuf_lstat, "lstat");
 }
 
 void
 test_stat(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
-
-	test_stat_path(&ntests, &lost_points);
-
-	ntests++;
-	result = any_empty(stat, "stat");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = any_badbuf(badbuf_stat, "stat");
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_stat_path();
+	any_empty(stat, "stat");
+	any_badbuf(badbuf_stat, "stat");
 }
 

userland/testbin/badcall/bad_symlink.c

@@ -37,47 +37,32 @@
 #include "test.h"
 
 static
-int
+void
 symlink_empty1(void)
 {
 	int rv;
-	int result;
 
 	report_begin("symlink -> empty string");
 	rv = symlink("", TESTLINK);
-	result = report_check2(rv, errno, 0, EINVAL);
+	report_check2(rv, errno, 0, EINVAL);
 	remove(TESTLINK);
-	return result;
 }
 
 static
-int
+void
 symlink_empty2(void)
 {
 	int rv;
 
 	report_begin("symlink named empty string");
 	rv = symlink("foo", "");
-	return report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 }
 
 void
 test_symlink(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
-
-
-	test_symlink_paths(&ntests, &lost_points);
-
-	ntests++;
-	result = symlink_empty1();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = symlink_empty2();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_symlink_paths();
+	symlink_empty1();
+	symlink_empty2();
 }

userland/testbin/badcall/bad_time.c

@@ -44,49 +44,33 @@
 #include "test.h"
 
 static
-int
+void
 time_badsecs(void *ptr, const char *desc)
 {
 	int rv;
 
 	report_begin("%s", desc);
 	rv = __time(ptr, NULL);
-	return report_check(rv, errno, EFAULT);
+	report_check(rv, errno, EFAULT);
 }
 
 static
-int
+void
 time_badnsecs(void *ptr, const char *desc)
 {
 	int rv;
 
 	report_begin("%s", desc);
 	rv = __time(NULL, ptr);
-	return report_check(rv, errno, EFAULT);
+	report_check(rv, errno, EFAULT);
 }
 
 void
 test_time(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	time_badsecs(INVAL_PTR, "__time with invalid seconds pointer");
+	time_badsecs(KERN_PTR, "__time with kernel seconds pointer");
 
-	ntests++;
-	result = time_badsecs(INVAL_PTR, "__time with invalid seconds pointer");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = time_badsecs(KERN_PTR, "__time with kernel seconds pointer");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = time_badnsecs(INVAL_PTR, "__time with invalid nsecs pointer");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = time_badnsecs(KERN_PTR, "__time with kernel nsecs pointer");
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	time_badnsecs(INVAL_PTR, "__time with invalid nsecs pointer");
+	time_badnsecs(KERN_PTR, "__time with kernel nsecs pointer");
 }

userland/testbin/badcall/bad_waitpid.c

@@ -42,7 +42,7 @@
 #include "test.h"
 
 static
-int
+void
 wait_badpid(pid_t pid, const char *desc)
 {
 	pid_t rv;
@@ -59,24 +59,23 @@ wait_badpid(pid_t pid, const char *desc)
 	else if (err == ENOSYS) {
 		report_saw_enosys();
 	}
-	return report_check2(rv, err, ESRCH, ECHILD);
+	report_check2(rv, err, ESRCH, ECHILD);
 }
 
 static
-int
+void
 wait_nullstatus(void)
 {
 	pid_t pid, rv;
 	int x;
-	int result;
 
 	report_begin("wait with NULL status");
 
 	pid = fork();
 	if (pid<0) {
 		report_warn("fork failed");
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 	if (pid==0) {
 		exit(0);
@@ -84,54 +83,50 @@ wait_nullstatus(void)
 
 	/* POSIX explicitly says passing NULL for status is allowed */
 	rv = waitpid(pid, NULL, 0);
-	result = report_check(rv, errno, 0);
+	report_check(rv, errno, 0);
 	waitpid(pid, &x, 0);
-	return result;
 }
 
 static
-int
+void
 wait_badstatus(void *ptr, const char *desc)
 {
 	pid_t pid, rv;
 	int x;
-	int result;
 
 	report_begin(desc);
 
 	pid = fork();
 	if (pid<0) {
 		report_warn("fork failed");
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 	if (pid==0) {
 		exit(0);
 	}
 
 	rv = waitpid(pid, ptr, 0);
-	result = report_check(rv, errno, EFAULT);
+	report_check(rv, errno, EFAULT);
 	waitpid(pid, &x, 0);
-	return result;
 }
 
 static
-int
+void
 wait_unaligned(void)
 {
 	pid_t pid, rv;
 	int x;
 	int status[2];	/* will have integer alignment */
 	char *ptr;
-	int result;
 
 	report_begin("wait with unaligned status");
 
 	pid = fork();
 	if (pid<0) {
 		report_warn("fork failed");
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 	if (pid==0) {
 		exit(0);
@@ -144,61 +139,55 @@ wait_unaligned(void)
 	ptr++;
 
 	rv = waitpid(pid, (int *)ptr, 0);
-	report_survival(rv, errno, &result);
+	report_survival(rv, errno);
 	if (rv<0) {
 		waitpid(pid, &x, 0);
 	}
-	return result;
 }
 
 static
-int
+void
 wait_badflags(void)
 {
 	pid_t pid, rv;
 	int x;
-	int result;
 
 	report_begin("wait with bad flags");
 
 	pid = fork();
 	if (pid<0) {
 		report_warn("fork failed");
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 	if (pid==0) {
 		exit(0);
 	}
 
 	rv = waitpid(pid, &x, 309429);
-	result = report_check(rv, errno, EINVAL);
+	report_check(rv, errno, EINVAL);
 	waitpid(pid, &x, 0);
-	return result;
 }
 
 static
-int
+void
 wait_self(void)
 {
 	pid_t rv;
 	int x;
-	int result;
 
 	report_begin("wait for self");
 
 	rv = waitpid(getpid(), &x, 0);
-	report_survival(rv, errno, &result);
-	return result;
+	report_survival(rv, errno);
 }
 
 static
-int
+void
 wait_parent(void)
 {
 	pid_t mypid, childpid, rv;
 	int x;
-	int result;
 
 	report_begin("wait for parent");
 	report_hassubs();
@@ -207,32 +196,30 @@ wait_parent(void)
 	childpid = fork();
 	if (childpid<0) {
 		report_warn("can't fork");
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 	if (childpid==0) {
 		/* Child. Wait for parent. */
 		rv = waitpid(mypid, &x, 0);
 		report_beginsub("from child:");
-		report_survival(rv, errno, &result);
+		report_survival(rv, errno);
 		_exit(0);
 	}
-	rv = waitpid(mypid, &x, 0);
+	rv = waitpid(childpid, &x, 0);
 	report_beginsub("from parent:");
-	report_survival(rv, errno, &result);
-	return result;
+	report_survival(rv, errno);
 }
 
 ////////////////////////////////////////////////////////////
 
 static
-int
+void
 wait_siblings_child(const char *semname)
 {
 	pid_t pids[2], mypid, otherpid;
 	int rv, fd, semfd, x;
 	char c;
-	int result;
 
 	mypid = getpid();
 
@@ -257,7 +244,7 @@ wait_siblings_child(const char *semname)
 	if (fd<0) {
 		report_warn("child process (pid %d) can't open %s",
 			    mypid, TESTFILE);
-		return FAILED;
+		return;
 	}
 
 	/*
@@ -270,13 +257,13 @@ wait_siblings_child(const char *semname)
 		if (rv<0) {
 			report_warn("child process (pid %d) lseek error",
 				    mypid);
-			return FAILED;
+			return;
 		}
 		rv = read(fd, pids, sizeof(pids));
 		if (rv<0) {
 			report_warn("child process (pid %d) read error",
 				    mypid);
-			return FAILED;
+			return;
 		}
 	} while (rv < (int)sizeof(pids));
 
@@ -289,25 +276,23 @@ wait_siblings_child(const char *semname)
 	else {
 		report_warn("child process (pid %d) got garbage in comm file",
 			    mypid);
-		return FAILED;
+		return;
 	}
 	close(fd);
 
 	rv = waitpid(otherpid, &x, 0);
 	report_beginsub("sibling (pid %d)", mypid);
-	report_survival(rv, errno, &result);
-	return result;
+	report_survival(rv, errno);
 }
 
 static
-int
+void
 wait_siblings(void)
 {
 	pid_t pids[2];
 	int rv, fd, semfd, x;
 	int bad = 0;
 	char semname[32];
-	int result;
 
 	/* This test may also blow up if FS synchronization is substandard */
 
@@ -318,26 +303,26 @@ wait_siblings(void)
 	semfd = open(semname, O_WRONLY|O_CREAT|O_TRUNC, 0664);
 	if (semfd < 0) {
 		report_warn("can't make semaphore");
-		report_aborted(&result);
-		return result;
+		report_aborted();
+		return;
 	}
 
 	fd = open_testfile(NULL);
 	if (fd<0) {
-		report_aborted(&result);
+		report_aborted();
 		close(semfd);
 		remove(semname);
-		return result;
+		return;
 	}
 
 	pids[0] = fork();
 	if (pids[0]<0) {
 		report_warn("can't fork");
-		report_aborted(&result);
+		report_aborted();
 		close(fd);
 		close(semfd);
 		remove(semname);
-		return result;
+		return;
 	}
 	if (pids[0]==0) {
 		close(fd);
@@ -349,12 +334,12 @@ wait_siblings(void)
 	pids[1] = fork();
 	if (pids[1]<0) {
 		report_warn("can't fork");
-		report_aborted(&result);
+		report_aborted();
 		/* abandon the other child process :( */
 		close(fd);
 		close(semfd);
 		remove(semname);
-		return result;
+		return;
 	}
 	if (pids[1]==0) {
 		close(fd);
@@ -366,21 +351,21 @@ wait_siblings(void)
 	rv = write(fd, pids, sizeof(pids));
 	if (rv < 0) {
 		report_warn("write error on %s", TESTFILE);
-		report_aborted(&result);
+		report_aborted();
 		/* abandon child procs :( */
 		close(fd);
 		close(semfd);
 		remove(semname);
-		return result;
+		return;
 	}
 	if (rv != (int)sizeof(pids)) {
 		report_warnx("write error on %s: short count", TESTFILE);
-		report_aborted(&result);
+		report_aborted();
 		/* abandon child procs :( */
 		close(fd);
 		close(semfd);
 		remove(semname);
-		return result;
+		return;
 	}
 
 	/* gate the child procs */
@@ -403,17 +388,15 @@ wait_siblings(void)
 	}
 	if (bad) {
 		/* XXX: aborted, or failure, or what? */
-		report_aborted(&result);
+		report_aborted();
 	}
 	else {
-		report_passed(&result);
+		report_passed();
 	}
 	close(fd);
 	close(semfd);
 	remove(semname);
 	remove(TESTFILE);
-
-	return result;
 }
 
 ////////////////////////////////////////////////////////////
@@ -421,61 +404,20 @@ wait_siblings(void)
 void
 test_waitpid(void)
 {
-	int ntests = 0, lost_points = 0;
-	int result;
+	wait_badpid(-8, "wait for pid -8");
+	wait_badpid(-1, "wait for pid -1");
+	wait_badpid(0, "pid zero");
+	wait_badpid(NONEXIST_PID, "nonexistent pid");
 
-	ntests++;
-	result = wait_badpid(-8, "wait for pid -8");
-	handle_result(result, &lost_points);
+	wait_nullstatus();
+	wait_badstatus(INVAL_PTR, "wait with invalid pointer status");
+	wait_badstatus(KERN_PTR, "wait with kernel pointer status");
 
-	ntests++;
-	result = wait_badpid(-1, "wait for pid -1");
-	handle_result(result, &lost_points);
+	wait_unaligned();
 
-	ntests++;
-	result = wait_badpid(0, "pid zero");
-	handle_result(result, &lost_points);
+	wait_badflags();
 
-	ntests++;
-	result = wait_badpid(NONEXIST_PID, "nonexistent pid");
-	handle_result(result, &lost_points);
-
-
-	ntests++;
-	result = wait_nullstatus();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = wait_badstatus(INVAL_PTR, "wait with invalid pointer status");
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = wait_badstatus(KERN_PTR, "wait with kernel pointer status");
-	handle_result(result, &lost_points);
-
-
-	ntests++;
-	result = wait_unaligned();
-	handle_result(result, &lost_points);
-
-
-	ntests++;
-	result = wait_badflags();
-	handle_result(result, &lost_points);
-
-
-	ntests++;
-	result = wait_self();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = wait_parent();
-	handle_result(result, &lost_points);
-
-	ntests++;
-	result = wait_siblings();
-	handle_result(result, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	wait_self();
+	wait_parent();
+	wait_siblings();
 }

userland/testbin/badcall/bad_write.c

@@ -36,11 +36,6 @@
 void
 test_write(void)
 {
-	int ntests = 0, lost_points = 0;
-
-	test_write_fd(&ntests, &lost_points);
-	test_write_buf(&ntests, &lost_points);
-
-	if(!lost_points)
-		success(TEST161_SUCCESS, SECRET, "/testbin/badcall");
+	test_write_fd();
+	test_write_buf();
 }

userland/testbin/badcall/common_buf.c

@@ -175,46 +175,33 @@ getcwd_badbuf(void *buf)
 ////////////////////////////////////////////////////////////
 
 static
-int
+void
 common_badbuf(struct buftest *info, void *buf, const char *bufdesc)
 {
 	int rv;
-	int result;
+
 
 	report_begin("%s with %s buffer", info->name, bufdesc);
 	info->setup();
 	rv = info->op(buf);
-	result = report_check(rv, errno, EFAULT);
+	report_check(rv, errno, EFAULT);
 	info->cleanup();
-	return result;
 }
 
 static
-int
-any_badbuf(struct buftest *info, int *ntests, int *lost_points)
+void
+any_badbuf(struct buftest *info)
 {
-	int result;
-
-	*ntests += 1;
-	result = common_badbuf(info, NULL, "NULL");
-	handle_result(result, lost_points);
-
-	*ntests += 1;
-	result = common_badbuf(info, INVAL_PTR, "invalid");
-	handle_result(result, lost_points);
-
-	*ntests += 1;
-	result = common_badbuf(info, KERN_PTR, "kernel-space");
-	handle_result(result, lost_points);
-
-	return result;
+	common_badbuf(info, NULL, "NULL");
+	common_badbuf(info, INVAL_PTR, "invalid");
+	common_badbuf(info, KERN_PTR, "kernel-space");
 }
 
 ////////////////////////////////////////////////////////////
 
 #define T(call) \
   void					\
-  test_##call##_buf(int *ntests, int *lost_points)		\
+  test_##call##_buf(void)		\
   {					\
   	static struct buftest info = {	\
   		call##_setup,		\
@@ -222,7 +209,7 @@ any_badbuf(struct buftest *info, int *ntests, int *lost_points)
   		call##_cleanup,		\
   		#call,			\
 	};				\
-   	any_badbuf(&info, ntests, lost_points);	\
+   	any_badbuf(&info);		\
   }
 
 T(read);

userland/testbin/badcall/common_fds.c

@@ -138,58 +138,46 @@ dup2_cleanup(void)
 ////////////////////////////////////////////////////////////
 
 static
-int
+void
 any_badfd(int (*func)(int fd), void (*cleanup)(void), const char *callname,
 	  int fd, const char *fddesc)
 {
 	int rv;
-	int result;
+
 	report_begin("%s using %s", callname, fddesc);
 	rv = func(fd);
-	result = report_check(rv, errno, EBADF);
+	report_check(rv, errno, EBADF);
 	if (cleanup) {
 		cleanup();
 	}
-	return result;
 }
 
 static
 void
 runtest(int (*func)(int fd), void (*cleanup)(void), const char *callname,
-	enum rwtestmodes rw, int *ntests, int *lost_points)
+	enum rwtestmodes rw)
 {
 	int fd;
-	int result;
 
 	/*
 	 * If adding cases, also see bad_dup2.c
 	 */
 
 	/* basic invalid case: fd -1 */
-	*ntests += 1;
-	result = any_badfd(func, cleanup, callname, -1, "fd -1");
-	handle_result(result, lost_points);
+	any_badfd(func, cleanup, callname, -1, "fd -1");
 
 	/* also try -5 in case -1 is special somehow */
-	*ntests += 1;
-	result = any_badfd(func, cleanup, callname, -5, "fd -5");
-	handle_result(result, lost_points);
+	any_badfd(func, cleanup, callname, -5, "fd -5");
 
 	/* try a fd we know is closed */
-	*ntests += 1;
-	result = any_badfd(func, cleanup, callname, CLOSED_FD, "closed fd");
-	handle_result(result, lost_points);
+	any_badfd(func, cleanup, callname, CLOSED_FD, "closed fd");
 
 	/* try a positive fd we know is out of range */
-	*ntests += 1;
-	result = any_badfd(func, cleanup, callname, IMPOSSIBLE_FD, "impossible fd");
-	handle_result(result, lost_points);
+	any_badfd(func, cleanup, callname, IMPOSSIBLE_FD, "impossible fd");
 
 	/* test for off-by-one errors */
 #ifdef OPEN_MAX
-	*ntests += 1;
-	result = any_badfd(func, cleanup, callname, OPEN_MAX, "fd OPEN_MAX");
-	handle_result(result, lost_points);
+	any_badfd(func, cleanup, callname, OPEN_MAX, "fd OPEN_MAX");
 #else
 	warnx("Warning: OPEN_MAX not defined, test skipped");
 #endif
@@ -200,10 +188,8 @@ runtest(int (*func)(int fd), void (*cleanup)(void), const char *callname,
 			/* already printed a message */
 		}
 		else {
-			*ntests += 1;
-			result = any_badfd(func, cleanup, callname, fd,
+			any_badfd(func, cleanup, callname, fd,
 				  "fd opened read-only");
-			handle_result(result, lost_points);
 		}
 		close(fd);
 	}
@@ -213,10 +199,8 @@ runtest(int (*func)(int fd), void (*cleanup)(void), const char *callname,
 			/* already printed a message */
 		}
 		else {
-			*ntests += 1;
-			result = any_badfd(func, cleanup, callname, fd,
+			any_badfd(func, cleanup, callname, fd,
 				  "fd opened write-only");
-			handle_result(result, lost_points);
 		}
 		close(fd);
 	}
@@ -224,18 +208,18 @@ runtest(int (*func)(int fd), void (*cleanup)(void), const char *callname,
 
 ////////////////////////////////////////////////////////////
 
-#define T(call, rw)                                                    \
-  void                                                                 \
-  test_##call##_fd(int *ntests, int *lost_points)                      \
-  {                                                                    \
-   	runtest(call##_badfd, NULL, #call, rw, ntests, lost_points);   \
+#define T(call, rw) \
+  void                                          \
+  test_##call##_fd(void)                        \
+  {                                             \
+   	runtest(call##_badfd, NULL, #call, rw); \
   }
 
-#define TC(call, rw)                                                           \
-  void                                                                         \
-  test_##call##_fd(int *ntests, int *lost_points)                              \
-  {                                                                            \
-   	runtest(call##_badfd, call##_cleanup, #call, rw, ntests, lost_points); \
+#define TC(call, rw) \
+  void                                          \
+  test_##call##_fd(void)                        \
+  {                                             \
+   	runtest(call##_badfd, call##_cleanup, #call, rw);\
   }
 
 T(read, RW_TEST_WRONLY);

userland/testbin/badcall/common_path.c

@@ -148,58 +148,46 @@ stat_badpath(const char *name)
 ////////////////////////////////////////////////////////////
 
 static
-int
+void
 common_badpath(int (*func)(const char *path), int mk, int rm, const char *path,
 	       const char *call, const char *pathdesc)
 {
 	int rv;
-	int result;
 
 	report_begin("%s with %s path", call, pathdesc);
 
 	if (mk) {
 		if (create_testfile()<0) {
-			report_aborted(&result);
-			return result;
+			report_aborted();
+			return;
 		}
 	}
 
 	rv = func(path);
-	result = report_check(rv, errno, EFAULT);
+	report_check(rv, errno, EFAULT);
 
 	if (mk || rm) {
 		remove(TESTFILE);
 	}
-	return result;
 }
 
 static
 void
-any_badpath(int (*func)(const char *path), const char *call, int mk, int rm,
-		int *ntests, int *lost_points)
+any_badpath(int (*func)(const char *path), const char *call, int mk, int rm)
 {
-	int result;
-	// We have a total of 3 tests
-	*ntests = *ntests + 3;
-
-	result = common_badpath(func, mk, rm, NULL, call, "NULL");
-	handle_result(result, lost_points);
-
-	result = common_badpath(func, mk, rm, INVAL_PTR, call, "invalid-pointer");
-	handle_result(result, lost_points);
-
-	result = common_badpath(func, mk, rm, KERN_PTR, call, "kernel-pointer");
-	handle_result(result, lost_points);
+	common_badpath(func, mk, rm, NULL, call, "NULL");
+	common_badpath(func, mk, rm, INVAL_PTR, call, "invalid-pointer");
+	common_badpath(func, mk, rm, KERN_PTR, call, "kernel-pointer");
 }
 
 ////////////////////////////////////////////////////////////
 
 /* functions with one pathname */
-#define T(call)                                                        \
-  void                                                                 \
-  test_##call##_path(int *ntests, int *lost_points)                    \
-  {                                                                    \
-   	any_badpath(call##_badpath, #call, 0, 0, ntests, lost_points); \
+#define T(call) \
+  void                                  \
+  test_##call##_path(void)              \
+  {                                     \
+   	any_badpath(call##_badpath, #call, 0, 0); \
   }
 
 T(open);
@@ -212,12 +200,12 @@ T(stat);
 T(lstat);
 
 /* functions with two pathnames */
-#define T2(call)                                                                 \
-  void                                                                           \
-  test_##call##_paths(int *ntests, int *lost_points)                             \
-  {                                                                              \
-   	any_badpath(call##_badpath1, #call "(arg1)", 0, 1, ntests, lost_points); \
-   	any_badpath(call##_badpath2, #call "(arg2)", 1, 1, ntests, lost_points); \
+#define T2(call) \
+  void                                  \
+  test_##call##_paths(void)             \
+  {                                     \
+   	any_badpath(call##_badpath1, #call "(arg1)", 0, 1); \
+   	any_badpath(call##_badpath2, #call "(arg2)", 1, 1); \
   }
 
 T2(rename);

userland/testbin/badcall/driver.c

@@ -121,18 +121,16 @@ int
 create_testdir(void)
 {
 	int rv;
-	int result;
-
 	rv = mkdir(TESTDIR, 0775);
 	if (rv<0) {
 		if (errno == ENOSYS) {
 			report_saw_enosys();
 			report_warnx("mkdir unimplemented; cannot run test");
-			report_skipped(&result);
+			report_skipped();
 		}
 		else {
 			report_warn("mkdir %s failed", TESTDIR);
-			report_aborted(&result);
+			report_aborted();
 		}
 		return -1;
 	}
@@ -200,20 +198,20 @@ menu(void)
 {
 	int i;
 	for (i=0; ops[i].name; i++) {
-		tprintf("[%c] %-24s", ops[i].ch, ops[i].name);
+		printf("[%c] %-24s", ops[i].ch, ops[i].name);
 		if (i%2==1) {
-			tprintf("\n");
+			printf("\n");
 		}
 	}
 	if (i%2==1) {
-		tprintf("\n");
+		printf("\n");
 	}
-	tprintf("[1] %-24s", "asst1");
-	tprintf("[2] %-24s\n", "asst2");
-	tprintf("[3] %-24s", "asst3");
-	tprintf("[4] %-24s\n", "asst4");
-	tprintf("[*] %-24s", "all");
-	tprintf("[!] %-24s\n", "quit");
+	printf("[1] %-24s", "asst1");
+	printf("[2] %-24s\n", "asst2");
+	printf("[3] %-24s", "asst3");
+	printf("[4] %-24s\n", "asst4");
+	printf("[*] %-24s", "all");
+	printf("[!] %-24s\n", "quit");
 }
 
 static
@@ -233,7 +231,7 @@ runit(int op)
 
 	if (op=='*') {
 		for (i=0; ops[i].name; i++) {
-			tprintf("[%s]\n", ops[i].name);
+			printf("[%s]\n", ops[i].name);
 			ops[i].f();
 		}
 		return;
@@ -243,7 +241,7 @@ runit(int op)
 		k = op-'0';
 		for (i=0; ops[i].name; i++) {
 			if (ops[i].asst <= k) {
-				tprintf("[%s]\n", ops[i].name);
+				printf("[%s]\n", ops[i].name);
 				ops[i].f();
 			}
 		}
@@ -251,7 +249,7 @@ runit(int op)
 	}
 
 	if (op < LOWEST || op > HIGHEST) {
-		tprintf("Invalid request %c\n", op);
+		printf("Invalid request %c\n", op);
 		return;
 	}
 
@@ -263,12 +261,12 @@ main(int argc, char **argv)
 {
 	int op, i, j;
 
-	tprintf("[%c-%c, 1-4, *, ?=menu, !=quit]\n", LOWEST, HIGHEST);
+	printf("[%c-%c, 1-4, *, ?=menu, !=quit]\n", LOWEST, HIGHEST);
 
 	if (argc > 1) {
 		for (i=1; i<argc; i++) {
 			for (j=0; argv[i][j]; j++) {
-				tprintf("Choose: %c\n",
+				printf("Choose: %c\n",
 				       argv[i][j]);
 				runit(argv[i][j]);
 			}
@@ -277,12 +275,12 @@ main(int argc, char **argv)
 	else {
 		menu();
 		while (1) {
-			tprintf("Choose: ");
+			printf("Choose: ");
 			op = getchar();
 			if (op==EOF) {
 				break;
 			}
-			tprintf("%c\n", op);
+			printf("%c\n", op);
 			runit(op);
 		}
 	}

userland/testbin/badcall/report.c

@@ -251,31 +251,27 @@ report_end(const char *msg)
 }
 
 void
-report_passed(int *status)
+report_passed(void)
 {
 	report_end("passed");
-	*status = SUCCESS;
 }
 
 void
-report_failure(int *status)
+report_failure(void)
 {
 	report_end("FAILURE");
-	*status = FAILED;
 }
 
 void
-report_skipped(int *status)
+report_skipped(void)
 {
 	report_end("------");
-	*status = SKIPPED;
 }
 
 void
-report_aborted(int *status)
+report_aborted(void)
 {
 	report_end("ABORTED");
-	*status = ABORTED;
 }
 
 ////////////////////////////////////////////////////////////
@@ -287,19 +283,18 @@ report_aborted(int *status)
  */
 
 void
-report_survival(int rv, int error, int *result)
+report_survival(int rv, int error)
 {
 	/* allow any error as long as we survive */
 	report_result(rv, error);
-	report_passed(result);
+	report_passed();
 }
 
 static
-int
+void
 report_checkN(int rv, int error, int *right_errors, int right_num)
 {
 	int i, goterror;
-	int result = 1;
 
 	if (rv==-1) {
 		goterror = error;
@@ -311,40 +306,39 @@ report_checkN(int rv, int error, int *right_errors, int right_num)
 	for (i=0; i<right_num; i++) {
 		if (goterror == right_errors[i]) {
 			report_result(rv, error);
-			report_passed(&result);
-			return result;
+			report_passed();
+			return;
 		}
 	}
 
 	if (goterror == ENOSYS) {
 		report_saw_enosys();
 		say("(unimplemented) ");
-		report_skipped(&result);
+		report_skipped();
 	}
 	else {
 		report_result(rv, error);
-		report_failure(&result);
+		report_failure();
 	}
-	return result;
 }
 
-int
+void
 report_check(int rv, int error, int right_error)
 {
-	return report_checkN(rv, error, &right_error, 1);
+	report_checkN(rv, error, &right_error, 1);
 }
 
-int
+void
 report_check2(int rv, int error, int okerr1, int okerr2)
 {
 	int ok[2];
 
 	ok[0] = okerr1;
 	ok[1] = okerr2;
-	return report_checkN(rv, error, ok, 2);
+	report_checkN(rv, error, ok, 2);
 }
 
-int
+void
 report_check3(int rv, int error, int okerr1, int okerr2, int okerr3)
 {
 	int ok[3];
@@ -352,13 +346,5 @@ report_check3(int rv, int error, int okerr1, int okerr2, int okerr3)
 	ok[0] = okerr1;
 	ok[1] = okerr2;
 	ok[2] = okerr3;
-	return report_checkN(rv, error, ok, 3);
+	report_checkN(rv, error, ok, 3);
 }
-
-void
-handle_result(int result, int *lost_points)
-{
-	if(result)
-		*lost_points = *lost_points + 1;
-}
-

userland/testbin/badcall/test.h

@@ -27,8 +27,6 @@
  * SUCH DAMAGE.
  */
 
-#include <test161/test161.h>
-
 #define TESTFILE "badcallfile"
 #define TESTDIR  "badcalldir"
 #define TESTLINK "badcalllink"
@@ -39,11 +37,6 @@
 #define PF(a, b)
 #endif
 
-#define SUCCESS 0
-#define SKIPPED	1
-#define FAILED	2
-#define ABORTED	3
-
 /* driver.c */
 int open_testfile(const char *str);
 int reopen_testfile(int openflags);
@@ -59,46 +52,46 @@ PF(1, 2) void report_warn(const char *fmt, ...);
 PF(1, 2) void report_warnx(const char *fmt, ...);
 void report_result(int rv, int error);
 void report_saw_enosys(void);
-void report_passed(int *result);
-void report_failure(int *result);
-void report_skipped(int *result);
-void report_aborted(int *result);
-void report_survival(int rv, int error, int *result);
-int  report_check(int rv, int error, int right_error);
-int  report_check2(int rv, int error, int okerr1, int okerr2);
-int  report_check3(int rv, int error, int okerr1, int okerr2, int okerr3);
+void report_passed(void);
+void report_failure(void);
+void report_skipped(void);
+void report_aborted(void);
+void report_survival(int rv, int error);
+void report_check(int rv, int error, int right_error);
+void report_check2(int rv, int error, int okerr1, int okerr2);
+void report_check3(int rv, int error, int okerr1, int okerr2, int okerr3);
 
 /* common_buf.c */
-void test_read_buf(int *ntests, int *lost_points);
-void test_write_buf(int *ntests, int *lost_points);
-void test_getdirentry_buf(int *ntests, int *lost_points);
-void test_getcwd_buf(int *ntests, int *lost_points);
-void test_readlink_buf(int *ntests, int *lost_points);
+void test_read_buf(void);
+void test_write_buf(void);
+void test_getdirentry_buf(void);
+void test_getcwd_buf(void);
+void test_readlink_buf(void);
 
 /* common_fds.c */
-void test_read_fd(int *ntests, int *lost_points);
-void test_write_fd(int *ntests, int *lost_points);
-void test_close_fd(int *ntests, int *lost_points);
-void test_ioctl_fd(int *ntests, int *lost_points);
-void test_lseek_fd(int *ntests, int *lost_points);
-void test_fsync_fd(int *ntests, int *lost_points);
-void test_ftruncate_fd(int *ntests, int *lost_points);
-void test_fstat_fd(int *ntests, int *lost_points);
-void test_getdirentry_fd(int *ntests, int *lost_points);
-void test_dup2_fd(int *ntests, int *lost_points);
+void test_read_fd(void);
+void test_write_fd(void);
+void test_close_fd(void);
+void test_ioctl_fd(void);
+void test_lseek_fd(void);
+void test_fsync_fd(void);
+void test_ftruncate_fd(void);
+void test_fstat_fd(void);
+void test_getdirentry_fd(void);
+void test_dup2_fd(void);
 
 /* common_path.c */
-void test_open_path(int *ntests, int *lost_points);
-void test_remove_path(int *ntests, int *lost_points);
-void test_rename_paths(int *ntests, int *lost_points);
-void test_link_paths(int *ntests, int *lost_points);
-void test_mkdir_path(int *ntests, int *lost_points);
-void test_rmdir_path(int *ntests, int *lost_points);
-void test_chdir_path(int *ntests, int *lost_points);
-void test_symlink_paths(int *ntests, int *lost_points);
-void test_readlink_path(int *ntests, int *lost_points);
-void test_stat_path(int *ntests, int *lost_points);
-void test_lstat_path(int *ntests, int *lost_points);
+void test_open_path(void);
+void test_remove_path(void);
+void test_rename_paths(void);
+void test_link_paths(void);
+void test_mkdir_path(void);
+void test_rmdir_path(void);
+void test_chdir_path(void);
+void test_symlink_paths(void);
+void test_readlink_path(void);
+void test_stat_path(void);
+void test_lstat_path(void);
 
 /* bad_*.c */
 void test_execv(void);
@@ -129,6 +122,3 @@ void test_time(void);
 void test_getcwd(void);
 void test_stat(void);
 void test_lstat(void);		/* in bad_stat.c */
-
-void handle_result(int result, int *lost_points);
-

userland/testbin/bigexec/bigexec.c

@@ -36,13 +36,11 @@
 
 #include <stdarg.h>
 #include <stdlib.h>
-#include <stdio.h>
 #include <string.h>
 #include <unistd.h>
 #include <limits.h>
 #include <assert.h>
 #include <err.h>
-#include <test161/test161.h>
 
 #define _PATH_MYSELF "/testbin/bigexec"
 
@@ -112,7 +110,6 @@ try(const char *first, ...)
 	va_list ap;
 	int num;
 
-	nprintf(".");
 	assert(first != NULL);
 	args[0] = _PATH_MYSELF;
 	args[1] = first;
@@ -127,7 +124,6 @@ try(const char *first, ...)
 		assert(num < 20);
 		args[num++] = s;
 	}
-	nprintf("\n");
 	assert(num < 20);
 	args[num] = NULL;
 	execv(_PATH_MYSELF, (char **)args);
@@ -141,12 +137,9 @@ trymany(int num, const char *word)
 	const char *args[num+2];
 	int i;
 
-	nprintf(".");
 	args[0] = _PATH_MYSELF;
 	for (i=0; i<num; i++) {
 		args[i+1] = word;
-		if(i%10)
-			nprintf(".");
 	}
 	args[num+1] = NULL;
 	execv(_PATH_MYSELF, (char **)args);
@@ -383,9 +376,7 @@ main(int argc, char *argv[])
 	}
 	else if (checkmany(argc, argv, 1000, word8)) {
 #endif
-		nprintf("\n");
 		warnx("Complete.");
-		success(TEST161_SUCCESS, SECRET, "/testbin/bigexec");
 		return 0;
 	}
 	else {
@@ -393,5 +384,4 @@ main(int argc, char *argv[])
 		dumpargs(argc, argv);
 		return 1;
 	}
-	success(TEST161_SUCCESS, SECRET, "/testbin/bigexec");
 }

userland/testbin/bigfile/bigfile.c

@@ -78,7 +78,7 @@ main(int argc, char *argv[])
 	/* round size up */
 	size = ((size + chunksize - 1) / chunksize) * chunksize;
 
-	tprintf("Creating a file of size %d in %d-byte chunks\n",
+	printf("Creating a file of size %d in %d-byte chunks\n",
 	       size, chunksize);
 
 	fd = open(filename, O_WRONLY|O_CREAT|O_TRUNC);

userland/testbin/bigfork/bigfork.c

@@ -44,8 +44,6 @@
 #include <string.h>
 #include <unistd.h>
 #include <err.h>
-#include <test/test.h>
-#include <test161/test161.h>
 
 #define BRANCHES 6
 
@@ -56,8 +54,6 @@
  */
 #define DIM 64
 
-#define PROGRESS_INTERVAL 25000
-
 static int m1[DIM*DIM], m2[DIM*DIM], m3[DIM*DIM], m4[DIM*DIM];
 static const int right[BRANCHES] = {
 	536763422,
@@ -80,9 +76,7 @@ init(void)
 		for (j=0; j<DIM; j++) {
 			m1[i*DIM+j] = random() % 11 - 5;
 		}
-		TEST161_LPROGRESS(0);
 	}
-	nprintf("\n");
 }
 
 static
@@ -102,15 +96,12 @@ static
 void
 mul(int *x, const int *a, const int *b)
 {
-	unsigned i, j, k, tot;
+	unsigned i, j, k;
 
-	tot = 0;
 	for (i=0; i<DIM; i++) {
 		for (j=0; j<DIM; j++) {
 			x[i*DIM+j] = 0;
 			for (k=0; k<DIM; k++) {
-				TEST161_LPROGRESS_N(tot, PROGRESS_INTERVAL);
-				tot++;
 				x[i*DIM+j] += a[i*DIM+k] * b[k*DIM+j]; 
 			}
 		}
@@ -186,15 +177,11 @@ dowait(pid_t pid)
 		exit(failures);
 	}
 	else {
-		// If the child crashes or waitpid returns -1, we don't know how many errors
-		// resulted (if any), but it's an error if we can't tell.
 		if (waitpid(pid, &status, 0) < 0) {
 			warn("waitpid(%d)", pid);
-			failures += 1;
 		}
 		else if (WIFSIGNALED(status)) {
 			warnx("pid %d: signal %d", pid, WTERMSIG(status));
-			failures += 1;
 		}
 		else if (WEXITSTATUS(status) > 0) {
 			failures += WEXITSTATUS(status);
@@ -209,6 +196,7 @@ dotest(void)
 	unsigned i, me;
 	pid_t pids[BRANCHES];
 	int t;
+	char msg[128];
 
 	me = 0;
 	for (i=0; i<BRANCHES; i++) {
@@ -219,28 +207,26 @@ dotest(void)
 		grind();
 		t = trace();
 		if (t == right[i]) {
-			lsay("\nStage %u #%u done: %d\n", i, me, trace());
+			snprintf(msg, sizeof(msg),
+				 "Stage %u #%u done: %d\n", i, me, trace());
 		}
 		else {
-			lsay("Stage %u #%u FAILED: got %d, expected %d\n",
+			snprintf(msg, sizeof(msg),
+				 "Stage %u #%u FAILED: got %d, expected %d\n",
 				 i, me, t, right[i]);
-			success(TEST161_FAIL, SECRET, "/testbin/bigfork");
 			failures++;
 		}
-		TEST161_LPROGRESS(0);
+		(void)write(STDOUT_FILENO, msg, strlen(msg));
 	}
 
 	for (i=BRANCHES; i-- > 0; ) {
 		dowait(pids[i]);
 	}
-
 	if (failures > 0) {
-		tprintf("%u failures.\n", failures);
-		success(TEST161_FAIL, SECRET, "/testbin/bigfork");
+		printf("%u failures.\n", failures);
 	}
 	else {
-		tprintf("Done.\n");
-		success(TEST161_SUCCESS, SECRET, "/testbin/bigfork");
+		printf("Done.\n");
 	}
 }
 

userland/testbin/bigseek/bigseek.c

@@ -182,7 +182,7 @@ static
 void
 try_seeking(int fd, off_t pos, off_t cursize)
 {
-	tprintf("Seeking to (and near) 0x%llx\n", pos);
+	printf("Seeking to (and near) 0x%llx\n", pos);
 
 	/* Go to the place. */
 	dolseek(fd, pos, SEEK_SET, "SEEK_SET", pos);
@@ -215,30 +215,30 @@ main(void)
 	off_t cursize;
 	int fd;
 
-	tprintf("Creating file...\n");
+	printf("Creating file...\n");
 	fd = open(TESTFILE, O_RDWR|O_CREAT|O_TRUNC, 0664);
 	if (fd < 0) {
 		err(1, "%s", TESTFILE);
 	}
 
-	tprintf("Writing something at offset 0\n");
+	printf("Writing something at offset 0\n");
 	write_slogan(fd, 0, false);
 	cursize = strlen(slogans[0]);
 
 	try_seeking(fd, (off_t)0x1000LL, cursize);
 
-	tprintf("Writing something else\n");
+	printf("Writing something else\n");
 	write_slogan(fd, 1, false);
 	cursize = (off_t)0x1000LL + strlen(slogans[1]);
 
 	try_seeking(fd, (off_t)0, cursize);
 
 	/* If seek is totally bust, this will fail. */
-	tprintf("Checking what we wrote\n");
+	printf("Checking what we wrote\n");
 	check_slogan(fd, 0);
 
 	try_seeking(fd, (off_t)0x1000LL, cursize);
-	tprintf("Checking the other thing we wrote\n");
+	printf("Checking the other thing we wrote\n");
 	check_slogan(fd, 1);
 
 	try_seeking(fd, (off_t)0x20LL, cursize);
@@ -250,19 +250,19 @@ main(void)
 	try_seeking(fd, (off_t)0x180000000LL, cursize);
 	try_seeking(fd, (off_t)0x180000020LL, cursize);
 
-	tprintf("Now trying to read (should get EOF)\n");
+	printf("Now trying to read (should get EOF)\n");
 	try_reading(fd);
 
-	tprintf("Now trying to write (should get EFBIG)\n");
+	printf("Now trying to write (should get EFBIG)\n");
 	try_writing(fd);
 
 	try_seeking(fd, (off_t)0x100000000LL, cursize);
 
 	/* If seek truncates to 32 bits, this might read the slogan instead */
-	tprintf("Trying to read again (should get EOF)\n");
+	printf("Trying to read again (should get EOF)\n");
 	try_reading(fd);
 
-	tprintf("Passed.\n");
+	printf("Passed.\n");
 
 	close(fd);
 	remove(TESTFILE);

userland/testbin/bloat/bloat.c

@@ -131,11 +131,11 @@ static
 void
 printsettings(void)
 {
-	tprintf("Page size: %u\n", PAGE_SIZE);
-	tprintf("Allocating %u pages and touching %u pages on each cycle.\n",
+	printf("Page size: %u\n", PAGE_SIZE);
+	printf("Allocating %u pages and touching %u pages on each cycle.\n",
 	       allocs, touchpages);
-	tprintf("Page selection bias: %u\n", bias);
-	tprintf("\n");
+	printf("Page selection bias: %u\n", bias);
+	printf("\n");
 }
 
 static

userland/testbin/crash/crash.c

@@ -46,8 +46,6 @@
 #include <unistd.h>
 #include <signal.h>
 #include <err.h>
-#include <test161/test161.h>
-
 
 #if defined(__mips__)
 #define KERNEL_ADDR	0x80000000
@@ -294,7 +292,7 @@ runop(int op)
 	/* intentionally don't check if op is in bounds :) */
 	opindex = op-'a';
 
-	tprintf("Running: [%c] %s\n", ops[opindex].ch, ops[opindex].name);
+	printf("Running: [%c] %s\n", ops[opindex].ch, ops[opindex].name);
 
 	if (forking) {
 		pid = fork();
@@ -309,25 +307,25 @@ runop(int op)
 			}
 			ok = 0;
 			if (WIFSIGNALED(status)) {
-				tprintf("Signal %d\n", WTERMSIG(status));
+				printf("Signal %d\n", WTERMSIG(status));
 				if (WTERMSIG(status) == ops[opindex].sig) {
 					ok = 1;
 				}
 			}
 			else {
-				tprintf("Exit %d\n", WEXITSTATUS(status));
+				printf("Exit %d\n", WEXITSTATUS(status));
 				if (WEXITSTATUS(status) == MAGIC) {
 					ok = 1;
 				}
 			}
 			if (ok) {
-				tprintf("Ok.\n");
+				printf("Ok.\n");
 			}
 			else {
-				tprintf("FAILED: expected signal %d\n",
+				printf("FAILED: expected signal %d\n",
 				       ops[opindex].sig);
 			}
-			tprintf("\n");
+			printf("\n");
 			return;
 		}
 	}
@@ -353,14 +351,14 @@ ask(void)
 	while (1) {
 
 		for (i=0; ops[i].name; i++) {
-			tprintf("[%c] %s\n", ops[i].ch, ops[i].name);
+			printf("[%c] %s\n", ops[i].ch, ops[i].name);
 		}
-		tprintf("[-] Disable forking\n");
-		tprintf("[+] Enable forking (default)\n");
-		tprintf("[*] Run everything\n");
-		tprintf("[!] Quit\n");
+		printf("[-] Disable forking\n");
+		printf("[+] Enable forking (default)\n");
+		printf("[*] Run everything\n");
+		printf("[!] Quit\n");
 
-		tprintf("Choose: ");
+		printf("Choose: ");
 		op = getchar();
 
 		if (op == '!') {
@@ -386,7 +384,5 @@ main(int argc, char **argv)
 			}
 		}
 	}
-	printf("Should print success\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/crash");
 	return 0;
 }

userland/testbin/ctest/ctest.c

@@ -38,7 +38,6 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <test161/test161.h>
 
 /*
  * SIZE is the amount of memory used.
@@ -65,12 +64,12 @@ main(int argc, char **argv)
 		stride = atoi(argv[1]);
 	}
 	if (stride <= 0 || argc > 2) {
-		tprintf("Usage: ctest [stridesize]\n");
-		tprintf("   stridesize should not be a multiple of 2.\n");
+		printf("Usage: ctest [stridesize]\n");
+		printf("   stridesize should not be a multiple of 2.\n");
 		return 1;
 	}
 
-	tprintf("Starting ctest: stride %d\n", stride);
+	printf("Starting ctest: stride %d\n", stride);
 
 	/*
 	 * Generate a huge linked list, with each entry pointing to
@@ -91,11 +90,12 @@ main(int argc, char **argv)
 	 */
 	e = &array[0];
 	for (i=0; i<SIZE; i++) {
-		TEST161_LPROGRESS_N(i, stride);
+		if (i % stride == 0) {
+			putchar('.');
+		}
 		e = e->e;
 	}
 
-	// Success is not crashing
-	success(TEST161_SUCCESS, SECRET, "/testbin/ctest");
+	printf("\nDone!\n");
 	return 0;
 }

userland/testbin/dirconc/dirconc.c

@@ -84,7 +84,7 @@ choose_name(char *buf, size_t len)
 
 /*
  * The purpose of this is to be atomic. In our world, straight
- * tprintf tends not to be.
+ * printf tends not to be.
  */
 static
 void

userland/testbin/dirseek/dirseek.c

@@ -205,7 +205,7 @@ firstread(void)
 		errx(1, ".: File position after open not 0");
 	}
 
-	tprintf("Scanning directory...\n");
+	printf("Scanning directory...\n");
 
 	readit();
 }
@@ -216,7 +216,7 @@ doreadat0(void)
 {
 	off_t pos;
 
-	tprintf("Rewinding directory and reading it again...\n");
+	printf("Rewinding directory and reading it again...\n");
 
 	pos = lseek(dirfd, 0, SEEK_SET);
 	if (pos < 0) {
@@ -274,7 +274,7 @@ readallonebyone(void)
 {
 	int i;
 
-	tprintf("Trying to read each entry again...\n");
+	printf("Trying to read each entry again...\n");
 	for (i=0; testfiles[i].name; i++) {
 		doreadone(i);
 	}
@@ -286,7 +286,7 @@ readallrandomly(void)
 {
 	int n, i, x;
 
-	tprintf("Trying to read a bunch of entries randomly...\n");
+	printf("Trying to read a bunch of entries randomly...\n");
 
 	for (i=0; testfiles[i].name; i++);
 	n = i;
@@ -327,7 +327,7 @@ doreadateof(void)
 	off_t pos;
 	int i;
 
-	tprintf("Trying to read after going to EOF...\n");
+	printf("Trying to read after going to EOF...\n");
 
 	pos = lseek(dirfd, 0, SEEK_END);
 	if (pos<0) {
@@ -364,7 +364,7 @@ dobadreads(void)
 	off_t pos, pos2, eof;
 	int valid, i, k=0;
 
-	tprintf("Trying some possibly invalid reads...\n");
+	printf("Trying some possibly invalid reads...\n");
 
 	eof = lseek(dirfd, 0, SEEK_END);
 	if (eof < 0) {
@@ -394,13 +394,13 @@ dobadreads(void)
 	}
 
 	if (k>0) {
-		tprintf("Survived %d invalid reads...\n", k);
+		printf("Survived %d invalid reads...\n", k);
 	}
 	else {
-		tprintf("Couldn't find any invalid offsets to try...\n");
+		printf("Couldn't find any invalid offsets to try...\n");
 	}
 
-	tprintf("Trying to read beyond EOF...\n");
+	printf("Trying to read beyond EOF...\n");
 	pos2 = lseek(dirfd, eof + 1000, SEEK_SET);
 	if (pos2 < 0) {
 		/* this is ok */
@@ -414,10 +414,10 @@ static
 void
 dotest(void)
 {
-	tprintf("Opening directory...\n");
+	printf("Opening directory...\n");
 	openit();
 
-	tprintf("Running tests...\n");
+	printf("Running tests...\n");
 
 	/* read the whole directory */
 	firstread();
@@ -443,7 +443,7 @@ dotest(void)
 	/* rewind again to make sure the invalid attempts didn't break it */
 	doreadat0();
 
-	tprintf("Closing directory...\n");
+	printf("Closing directory...\n");
 	closeit();
 }
 
@@ -489,7 +489,7 @@ setup(void)
 {
 	int i;
 
-	tprintf("Making directory %s...\n", TESTDIR);
+	printf("Making directory %s...\n", TESTDIR);
 
 	/* Create a directory */
 	if (mkdir(TESTDIR, 0775)<0) {
@@ -501,7 +501,7 @@ setup(void)
 		err(1, "%s: chdir", TESTDIR);
 	}
 
-	tprintf("Making some files...\n");
+	printf("Making some files...\n");
 
 	/* Populate it */
 	for (i=0; testfiles[i].name; i++) {
@@ -518,7 +518,7 @@ cleanup(void)
 {
 	int i;
 
-	tprintf("Cleaning up...\n");
+	printf("Cleaning up...\n");
 
 	/* Remove the files */
 	for (i=0; testfiles[i].name; i++) {

userland/testbin/dirtest/dirtest.c

@@ -58,7 +58,7 @@ main(void)
 	strcpy(dirname, onename);
 
 	for (i=0; i<MAXLEVELS; i++) {
-		tprintf("Creating directory: %s\n", dirname);
+		printf("Creating directory: %s\n", dirname);
 
 		if (mkdir(dirname, 0755)) {
 			err(1, "%s: mkdir", dirname);
@@ -68,18 +68,18 @@ main(void)
 		strcat(dirname, onename);
 	}
 
-	tprintf("Passed directory creation test.\n");
+	printf("Passed directory creation test.\n");
 
 	for (i=0; i<MAXLEVELS; i++) {
 		dirname[strlen(dirname) - strlen(onename) - 1] = 0;
 
-		tprintf("Removing directory: %s\n", dirname);
+		printf("Removing directory: %s\n", dirname);
 
 		if (rmdir(dirname)) {
 			err(1, "%s: rmdir", dirname);
 		}
 	}
-	tprintf("Passed directory removal test.\n");
+	printf("Passed directory removal test.\n");
 
 	return 0;
 }

userland/testbin/f_test/f_read.c

@@ -79,7 +79,7 @@ subproc_read(void)
 	int fd;
 	int i, res;
 
-	tprintf("File Reader starting ...\n\n");
+	printf("File Reader starting ...\n\n");
 
 	fd = open(FNAME, O_RDONLY);
 	if (fd < 0) {
@@ -102,5 +102,5 @@ subproc_read(void)
 
 	close(fd);
 
-	tprintf("File Read exited successfully!\n");
+	printf("File Read exited successfully!\n");
 }

userland/testbin/f_test/f_test.c

@@ -124,8 +124,8 @@ big_file(int size)
 {
 	int i, j, fileid;
 
-	tprintf("[BIGFILE] test starting :\n");
-	tprintf("\tCreating a file of size: %d\n", size);
+	printf("[BIGFILE] test starting :\n");
+	printf("\tCreating a file of size: %d\n", size);
 
 	fileid = open(BIGFILE_NAME, O_WRONLY|O_CREAT|O_TRUNC, 0664);
 	if (fileid < 0) {
@@ -136,16 +136,16 @@ big_file(int size)
 		fbuffer[i] = LETTER(i);
 	}
 
-	tprintf("\tWriting to file.\n");
+	printf("\tWriting to file.\n");
 	for (i = 0; i < size; i += BUFFER_SIZE) {
 		write(fileid, fbuffer, BUFFER_SIZE);
 
 		if (!(i % (10 * BUFFER_SIZE))) {
-			tprintf("\rBW : %d", i);
+			printf("\rBW : %d", i);
 		}
 	}
 
-	tprintf("\n\tReading from file.\n");
+	printf("\n\tReading from file.\n");
 	close(fileid);
 
 	fileid = open(BIGFILE_NAME, O_RDONLY);
@@ -164,7 +164,7 @@ big_file(int size)
 	}
 
 	if (!(i % (10 * BUFFER_SIZE))) {
-		tprintf("\rBR : %d", i);
+		printf("\rBR : %d", i);
 	}
 
 	/* Check to see that the data is consistent : */
@@ -181,7 +181,7 @@ big_file(int size)
 		err(1, "[BIGFILE]: %s: remove", BIGFILE_NAME);
 	}
 
-	tprintf("\n[BIGFILE] : Success!\n");
+	printf("\n[BIGFILE] : Success!\n");
 }
 
 /* ===================================================
@@ -195,7 +195,7 @@ concur(void)
 	int i, fd;
 	int r1, r2, w1;
 
-	tprintf("Spawning 2 readers, 1 writer.\n");
+	printf("Spawning 2 readers, 1 writer.\n");
 
 
 	fd = open(FNAME, O_WRONLY|O_CREAT|O_TRUNC, 0664);
@@ -203,7 +203,7 @@ concur(void)
 		err(1, "[CONCUR]: %s: open", FNAME);
 	}
 
-	tprintf("Initializing test file: ");
+	printf("Initializing test file: ");
 
 	for (i = 0; i < SECTOR_SIZE + 1; i++) {
 		cbuffer[i] = READCHAR;
@@ -216,13 +216,13 @@ concur(void)
 
 	close(fd);
 
-	tprintf("Done initializing. Starting processes...\n");
+	printf("Done initializing. Starting processes...\n");
 
 	r1 = forkoff(subproc_read);
 	w1 = forkoff(subproc_write);
 	r2 = forkoff(subproc_read);
 
-	tprintf("Waiting for processes.\n");
+	printf("Waiting for processes.\n");
 
 	dowait(r1);
 	dowait(r2);
@@ -232,7 +232,7 @@ concur(void)
 		err(1, "[CONCUR]: %s: remove", FNAME);
 	}
 
-	tprintf("[CONCUR] Done!\n");
+	printf("[CONCUR] Done!\n");
 }
 
 /* ===================================================
@@ -253,14 +253,14 @@ dir_test(int depth)
 	for (i = 0; i < depth; i++) {
 		strcat(dirname, tmp);
 
-		tprintf("\tCreating dir : %s\n", dirname);
+		printf("\tCreating dir : %s\n", dirname);
 
 		if (mkdir(dirname, 0775) < 0) {
 			err(1, "[DIRTEST]: %s: mkdir", dirname);
 		}
 
 		strcat(dirname, fmp);
-		tprintf("\tCreating file: %s\n", dirname);
+		printf("\tCreating file: %s\n", dirname);
 
 		fd = open(dirname, O_WRONLY|O_CREAT|O_TRUNC, 0664);
 		if (fd<0) {
@@ -270,19 +270,19 @@ dir_test(int depth)
 		dirname[strlen(dirname) - strlen(fmp)] = '\0';
 	}
 
-	tprintf("[DIRTEST] : Passed directory creation test.\n");
+	printf("[DIRTEST] : Passed directory creation test.\n");
 
 	for (i = 0; i < depth; i++) {
 		strcat(dirname, fmp);
 
-		tprintf("\tDeleting file: %s\n", dirname);
+		printf("\tDeleting file: %s\n", dirname);
 
 		if (remove(dirname)) {
 			 err(1, "[DIRTEST]: %s: remove", dirname);
 		}
 
 		dirname[strlen(dirname) - strlen(fmp)] = '\0';
-		tprintf("\tRemoving dir : %s\n", dirname);
+		printf("\tRemoving dir : %s\n", dirname);
 
 		if (rmdir(dirname)) {
 			err(1, "[DIRTEST]: %s: rmdir", dirname);
@@ -291,8 +291,8 @@ dir_test(int depth)
 		dirname[strlen(dirname) - strlen(tmp)] = '\0';
 	}
 
-	tprintf("[DIRTEST] : Passed directory removal test.\n");
-	tprintf("[DIRTEST] : Success!\n");
+	printf("[DIRTEST] : Passed directory removal test.\n");
+	printf("[DIRTEST] : Success!\n");
 }
 
 /* ===================================================
@@ -325,21 +325,21 @@ main(int argc, char * argv[])
 	}
 
 	if (tv & RUNBIGFILE) {
-		tprintf("[BIGFILE] : Run #1\n");
+		printf("[BIGFILE] : Run #1\n");
 		big_file(BIGFILE_SIZE);
-		tprintf("[BIGFILE] : Run #2\n");
+		printf("[BIGFILE] : Run #2\n");
 		big_file(BIGFILE_SIZE);
 	}
 
 	if (tv & RUNDIRTEST) {
-		tprintf("[DIRTEST] : Run #1\n");
+		printf("[DIRTEST] : Run #1\n");
 		dir_test(DIR_DEPTH);
-		tprintf("[DIRTEST] : Run #2\n");
+		printf("[DIRTEST] : Run #2\n");
 		dir_test(DIR_DEPTH);
 	}
 
 	if (tv & RUNCONCUR) {
-		tprintf("[CONCUR]\n");
+		printf("[CONCUR]\n");
 		concur();
 	}
 	return 0;

userland/testbin/f_test/f_write.c

@@ -67,7 +67,7 @@ subproc_write(void)
 		buffer[i] = WRITECHAR;
 	}
 
-	tprintf("File Writer starting ...\n");
+	printf("File Writer starting ...\n");
 
 	fd = open(FNAME, O_WRONLY);
 	if (fd < 0) {
@@ -81,5 +81,5 @@ subproc_write(void)
 
 	close(fd);
 
-	tprintf("File Write exited successfully!\n");
+	printf("File Write exited successfully!\n");
 }

userland/testbin/factorial/factorial.c

@@ -32,7 +32,6 @@
 #include <unistd.h>
 #include <assert.h>
 #include <err.h>
-#include <test161/test161.h>
 
 #define _PATH_SELF "/testbin/factorial"
 
@@ -246,12 +245,9 @@ main(int argc, char *argv[])
 	}
 	else if (argc == 3) {
 		if (!strcmp(argv[1], "1") || !strcmp(argv[1], "0")) {
-			nprintf("\n");
-			tprintf("%s\n", argv[2]);
-			secprintf(SECRET, argv[2], "/testbin/factorial");
+			printf("%s\n", argv[2]);
 		}
 		else {
-			nprintf(".");
 			number_init(&n1, argv[1]);
 			number_init(&n2, argv[2]);
 			number_init(&multbuf, "0");

userland/testbin/faulter/faulter.c

@@ -45,12 +45,12 @@ main(void)
 {
 	volatile int i;
 
-	tprintf("\nEntering the faulter program - I should die immediately\n");
+	printf("\nEntering the faulter program - I should die immediately\n");
 	i = *(int *)REALLY_BIG_ADDRESS;
 
 	// gcc 4.8 improperly demands this
 	(void)i;
 
-	tprintf("I didn't get killed!  Program has a bug\n");
+	printf("I didn't get killed!  Program has a bug\n");
 	return 0;
 }

userland/testbin/filetest/filetest.c

@@ -103,6 +103,6 @@ main(int argc, char *argv[])
 	if (rv<0) {
 		err(1, "%s: remove", file);
 	}
-	tprintf("Passed filetest.\n");
+	printf("Passed filetest.\n");
 	return 0;
 }

userland/testbin/forkbomb/forkbomb.c

@@ -49,11 +49,6 @@
 
 #include <unistd.h>
 #include <err.h>
-#include <time.h>
-#include <test161/test161.h>
-
-#define TEST_DURATION 10
-#define LOCAL_SUCCESS "SUCCESS"
 
 static volatile int pid;
 
@@ -62,40 +57,8 @@ main(void)
 {
 	int i;
 
-	time_t start_time_s, time_now_s;
-	unsigned long start_time_ns, time_now_ns;
-	__time(&start_time_s, &start_time_ns);
-	int parent_pid = getpid();
-	int did_print = 0;
-	int iters = 0;
-
-	// Do not remove!
-	// We need to cause page faults on the static secprintf buffers so the
-	// pages are available when we print success. With on-demand page allocation,
-	// we will probably be out of pages by the time we try to print success.
-	secprintf(SECRET, "!!< Starting Forkbbbboooommmmbbbb >!!", "/testbin/forkbomb");
-
-	// And now for the success string
-	printf("This should print %s after 10s\n", LOCAL_SUCCESS);
-
 	while (1) {
 		fork();
-		// Only parent gets to print
-		if(getpid() == parent_pid) {
-			TEST161_LPROGRESS(0);
-			if (iters > 0 && iters % 20 == 0) {
-				putchar('\n');
-			}
-			iters++;
-
-			__time(&time_now_s, &time_now_ns);
-			if (time_now_s - start_time_s > TEST_DURATION && !did_print) {
-				did_print = 1;
-				// We need to print this using secprintf so that it uses
-				// the same page we warmed up earlier.
-				secprintf(SECRET, LOCAL_SUCCESS, "/testbin/forkbomb");
-			}
-		}
 
 		pid = getpid();
 

userland/testbin/forktest/forktest.c

@@ -37,16 +37,10 @@
  */
 
 #include <unistd.h>
-#include <fcntl.h>
 #include <string.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <err.h>
-#include <test161/test161.h>
-
-#define FORKTEST_FILENAME_BASE "forktest"
-
-static char filename[32];
 
 /*
  * This is used by all processes, to try to help make sure all
@@ -54,18 +48,6 @@ static char filename[32];
  */
 static volatile int mypid;
 
-/*
- * Helper function to do pow()
- */
-static
-int pow_int(int x, int y) {
-	int i;
-	int result = 1;
-	for(i = 0; i < y; i++)
-		result *= x;
-	return result;
-}
-
 /*
  * Helper function for fork that prints a warning on error.
  */
@@ -95,7 +77,6 @@ check(void)
 	mypid = getpid();
 
 	/* Make sure each fork has its own address space. */
-	nprintf(".");
 	for (i=0; i<800; i++) {
 		volatile int seenpid;
 		seenpid = mypid;
@@ -133,13 +114,13 @@ dowait(int nowait, int pid)
 
 	if (!nowait) {
 		if (waitpid(pid, &x, 0)<0) {
-			errx(1, "waitpid");
+			warn("waitpid");
 		}
 		else if (WIFSIGNALED(x)) {
-			errx(1, "pid %d: signal %d", pid, WTERMSIG(x));
+			warnx("pid %d: signal %d", pid, WTERMSIG(x));
 		}
 		else if (WEXITSTATUS(x) != 0) {
-			errx(1, "pid %d: exit %d", pid, WEXITSTATUS(x));
+			warnx("pid %d: exit %d", pid, WEXITSTATUS(x));
 		}
 	}
 }
@@ -160,42 +141,17 @@ test(int nowait)
 	 * to prevent wait/exit problems if fork corrupts memory.
 	 */
 
-	/*
-	 * Guru: We have a problem here.
-	 * We need to write the output to a file since test161 is
-	 * supposed to be as simple as possible. This requires the
-	 * test to tell test161 whether it passed or succeeded.
-	 * We cannot lseek and read stdout, to check the output,
-	 * so we need to write the output to a file and then check it later.
-	 *
-	 * So far so good. However, if in the future, forktest is
-	 * going to be combined with triple/quint/etc, then the filename
-	 * cannot be the same across multiple copies. So we need a
-	 * unique filename per instance of forktest.
-	 * So...
-	 */
-	snprintf(filename, 32, "%s-%d.bin", FORKTEST_FILENAME_BASE, getpid());
-	int fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC);
-	if(fd < 3) {
-		// 0, 1, 2 are stdin, stdout, stderr
-		err(1, "Failed to open file to write data into\n");
-	}
-
 	pid0 = dofork();
-	nprintf(".");
-	write(fd, "A", 1);
+	putchar('A');
 	check();
 	pid1 = dofork();
-	nprintf(".");
-	write(fd, "B", 1);
+	putchar('B');
 	check();
 	pid2 = dofork();
-	nprintf(".");
-	write(fd, "C", 1);
+	putchar('C');
 	check();
 	pid3 = dofork();
-	nprintf(".");
-	write(fd, "D", 1);
+	putchar('D');
 	check();
 
 	/*
@@ -203,57 +159,11 @@ test(int nowait)
 	 * improperly.
 	 */
 	dowait(nowait, pid3);
-	nprintf(".");
 	dowait(nowait, pid2);
-	nprintf(".");
 	dowait(nowait, pid1);
-	nprintf(".");
 	dowait(nowait, pid0);
-	nprintf(".");
 
-	// Check if file contents are correct
-	// lseek may not be implemented..so close and reopen
-	close(fd);
-	fd = open(filename, O_RDONLY);
-	if(fd < 3) {
-		err(1, "Failed to open file for verification\n");
-	}
-	nprintf(".");
-
-	char buffer[30];
-	int len;
-	int char_idx, i;
-	int observed, expected;
-	char character = 'A';
-
-	memset(buffer, 0, 30);
-	len = read(fd, buffer, 30);
-	printf("\n%s\n", buffer);
-	if(len != 30) {
-		err(1, "Did not get expected number of characters\n");
-	}
-	nprintf(".");
-	// Check if number of instances of each character is correct
-	// 2As; 4Bs; 8Cs; 16Ds
-	for(char_idx = 0; char_idx < 4; char_idx++) {
-		nprintf(".");
-		observed = 0;
-		expected = pow_int(2, char_idx + 1);
-		for(i = 0; i < 30; i++) {
-			// In C, char can be directly converted to an ASCII index
-			// So, A is 65, B is 66, ...
-			if(buffer[i] == character + char_idx) {
-				observed++;
-			}
-		}
-		if(observed != expected) {
-			// Failed
-			err(1, "Failed! Expected %d%cs..observed: %d\n", expected, character + char_idx, observed);
-		}
-	}
-	nprintf("\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/forktest");
-	close(fd);
+	putchar('\n');
 }
 
 int

userland/testbin/frack/check.c

@@ -2148,7 +2148,7 @@ doindent(unsigned depth)
 	unsigned i;
 
 	for (i=0; i<depth; i++) {
-		tprintf("   ");
+		printf("   ");
 	}
 }
 
@@ -2174,17 +2174,17 @@ printdiffs(unsigned indent, struct fsobject *obja, struct fsobject *objb)
 		     entb = entb->next) {
 			if (enta->name == entb->name) {
 				doindent(indent);
-				tprintf("%s", name_get(enta->name));
+				printf("%s", name_get(enta->name));
 				if (enta->obj->isdir &&
 				    !entb->obj->isdir) {
-					tprintf(": expected dir, found file;");
-					tprintf(" %u names missing.\n",
+					printf(": expected dir, found file;");
+					printf(" %u names missing.\n",
 					       count_subtree(enta->obj) - 1);
 				}
 				else if (!enta->obj->isdir &&
 					 entb->obj->isdir) {
-					tprintf(": expected file, found dir;");
-					tprintf(" %u extra names.\n",
+					printf(": expected file, found dir;");
+					printf(" %u extra names.\n",
 					       count_subtree(entb->obj) - 1);
 				}
 				else if (!enta->obj->isdir &&
@@ -2194,18 +2194,18 @@ printdiffs(unsigned indent, struct fsobject *obja, struct fsobject *objb)
 					alen = enta->obj->obj_file.len;
 					blen = entb->obj->obj_file.len;
 					if (alen == blen) {
-						tprintf("\t\t%lld bytes (ok)\n",
+						printf("\t\t%lld bytes (ok)\n",
 						       alen);
 					}
 					else {
-						tprintf(": found %lld bytes, "
+						printf(": found %lld bytes, "
 						       "expected %lld "
 						       "bytes.\n",
 						       blen, alen);
 					}
 				}
 				else {
-					tprintf("/\n");
+					printf("/\n");
 					printdiffs(indent + 1,
 						   enta->obj, entb->obj);
 				}
@@ -2215,13 +2215,13 @@ printdiffs(unsigned indent, struct fsobject *obja, struct fsobject *objb)
 		}
 		if (!found) {
 			doindent(indent);
-			tprintf("%s: missing ", name_get(enta->name));
+			printf("%s: missing ", name_get(enta->name));
 			if (enta->obj->isdir) {
-				tprintf("subtree with %u names.\n",
+				printf("subtree with %u names.\n",
 				       count_subtree(enta->obj) - 1);
 			}
 			else {
-				tprintf("file\n");
+				printf("file\n");
 			}
 		}
 	}
@@ -2238,13 +2238,13 @@ printdiffs(unsigned indent, struct fsobject *obja, struct fsobject *objb)
 		}
 		if (!found) {
 			doindent(indent);
-			tprintf("%s: extra ", name_get(entb->name));
+			printf("%s: extra ", name_get(entb->name));
 			if (entb->obj->isdir) {
-				tprintf("subtree with %u names.\n",
+				printf("subtree with %u names.\n",
 				       count_subtree(entb->obj) - 1);
 			}
 			else {
-				tprintf("file\n");
+				printf("file\n");
 			}
 		}
 	}
@@ -2326,7 +2326,7 @@ checkfilezeros(int fd, const char *namestr, off_t start, off_t end)
 	unsigned poison = 0, trash = 0;
 	off_t origstart = start;
 
-	tprintf("   %lld - %lld (expecting zeros)\n", start, end);
+	printf("   %lld - %lld (expecting zeros)\n", start, end);
 
 	if (lseek(fd, start, SEEK_SET) == -1) {
 		err(1, "%s: lseek to %lld", namestr, start);
@@ -2356,19 +2356,19 @@ checkfilezeros(int fd, const char *namestr, off_t start, off_t end)
 		start += ret;
 	}
 	if (poison > 0 || trash > 0) {
-		tprintf("ERROR: File %s: expected zeros from %lld to %lld; "
+		printf("ERROR: File %s: expected zeros from %lld to %lld; "
 		       "found",
 		       namestr, origstart, end);
 		if (poison > 0) {
-			tprintf(" %u poison bytes", poison);
+			printf(" %u poison bytes", poison);
 			if (trash > 0) {
-				tprintf(" and");
+				printf(" and");
 			}
 		}
 		if (trash > 0) {
-			tprintf(" %u trash bytes", trash);
+			printf(" %u trash bytes", trash);
 		}
-		tprintf("\n");
+		printf("\n");
 	}
 }
 
@@ -2440,7 +2440,7 @@ checkfiledata(int fd, const char *namestr, unsigned code, unsigned seq,
 		checkend = regionend;
 	}
 
-	tprintf("   %lld - %lld\n", checkstart, checkend);
+	printf("   %lld - %lld\n", checkstart, checkend);
 
 	readfiledata(fd, namestr,
 		     regionstart, checkstart, checkend, regionend);
@@ -2695,7 +2695,7 @@ checkonefilecontents(const char *namestr, struct fsobject *file,
 			return;
 		}
 		assert(change->type == FC_WRITE);
-		tprintf("ERROR: File %s is zero length but was expected to "
+		printf("ERROR: File %s is zero length but was expected to "
 		       "contain at least %lld bytes at offset %lld!\n",
 		       namestr, change->fc_write.pos, change->fc_write.len);
 		close(fd);
@@ -2704,7 +2704,7 @@ checkonefilecontents(const char *namestr, struct fsobject *file,
 
 	/* XXX: this check is wrong too. */
 	if (change->type == FC_CREAT) {
-		tprintf("ERROR: File %s was never written to but has "
+		printf("ERROR: File %s was never written to but has "
 		       "length %lld\n",
 		       namestr, file->obj_file.len);
 		close(fd);
@@ -2741,12 +2741,12 @@ checkonefilecontents(const char *namestr, struct fsobject *file,
 	 */
 	while (!change_is_present(fd, namestr, file->obj_file.len, change)) {
 		if (change->version < okversion) {
-			tprintf("File %s: change for version %u is missing\n",
+			printf("File %s: change for version %u is missing\n",
 			       namestr, change->version);
 		}
 		change = backup_for_file(change->prev,file->obj_file.identity);
 		if (change == NULL) {
-			tprintf("File %s: no matching version found\n",
+			printf("File %s: no matching version found\n",
 			       namestr);
 			close(fd);
 			return;
@@ -2781,18 +2781,18 @@ checkallfilecontents(struct fsobject *dir, struct fschange *change)
 	for (de = dir->obj_dir.entries; de != NULL; de = de->next) {
 		namestr = name_get(de->name);
 		if (de->obj->isdir) {
-			tprintf(" >>> Entering %s\n", namestr);
+			printf(" >>> Entering %s\n", namestr);
 			if (chdir(namestr)) {
 				err(1, "%s: chdir", namestr);
 			}
 			checkallfilecontents(de->obj, change);
-			tprintf(" <<< Leaving %s\n", namestr);
+			printf(" <<< Leaving %s\n", namestr);
 			if (chdir("..")) {
 				err(1, "..: chdir");
 			}
 		}
 		else {
-			tprintf("%s...\n", namestr);
+			printf("%s...\n", namestr);
 			checkonefilecontents(namestr, de->obj, change);
 		}
 	}
@@ -2813,7 +2813,7 @@ checkfs(void)
 	/*
 	 * We just built the model; talk about it.
 	 */
-	tprintf("Established %u versions across %u directories and %u files\n",
+	printf("Established %u versions across %u directories and %u files\n",
 	       changes->version + 1, nextdirnum, nextfilenum);
 
 	/*
@@ -2821,7 +2821,7 @@ checkfs(void)
 	 * FOUND holding the found volume state.
 	 */
 	inspectfs();
-	tprintf("Found %u subdirs and %u files on the volume\n",
+	printf("Found %u subdirs and %u files on the volume\n",
 	       found_subdirs, found_files);
 
 	/*
@@ -2856,7 +2856,7 @@ checkfs(void)
 			best = change;
 			bestscore = score;
 		}
-		//tprintf("version %u score %u\n", change->version, score);
+		//printf("version %u score %u\n", change->version, score);
 		change = change->next;
 	}
 	assert(best != NULL);
@@ -2874,9 +2874,9 @@ checkfs(void)
 		 * differences. XXX: this results in not checking file
 		 * data...
 		 */
-		tprintf("FAILURE: Directory tree does not match on any "
+		printf("FAILURE: Directory tree does not match on any "
 		       "version.\n");
-		tprintf("Best version is %u; describing differences:\n",
+		printf("Best version is %u; describing differences:\n",
 		       best->version);
 		printdiffs(1, state, found);
 		return;
@@ -2886,9 +2886,9 @@ checkfs(void)
 	 * Ok, we did get an exact match. Print it.
 	 */
 
-	tprintf("Directory tree matched in version %u.\n", best->version);
+	printf("Directory tree matched in version %u.\n", best->version);
 	if (best->partial) {
-		tprintf("WARNING: this is a version from a partially committed "
+		printf("WARNING: this is a version from a partially committed "
 		       "operation.\n");
 	}
 
@@ -2905,7 +2905,7 @@ checkfs(void)
 
 	/* now check the file contents */
 
-	tprintf("Checking file contents...\n");
+	printf("Checking file contents...\n");
 	checkallfilecontents(state, best);
-	tprintf("Done.\n");
+	printf("Done.\n");
 }

userland/testbin/frack/data.c

@@ -165,7 +165,7 @@ data_matches(const char *namestr, off_t regionoffset,
 		}
 		else if (zero_at(where, howmuch)) {
 			if (where >= zerostart) {
-				tprintf("WARNING: file %s range %lld-%lld is "
+				printf("WARNING: file %s range %lld-%lld is "
 				       "zeroed\n",
 				       namestr, regionoffset + where,
 				       regionoffset + where + howmuch);
@@ -176,7 +176,7 @@ data_matches(const char *namestr, off_t regionoffset,
 		}
 		else if (poison_at(where, howmuch)) {
 			if (where >= zerostart) {
-				tprintf("ERROR: file %s range %lld-%lld is "
+				printf("ERROR: file %s range %lld-%lld is "
 				       "poisoned\n",
 				       namestr, regionoffset + where,
 				       regionoffset + where + howmuch);
@@ -205,7 +205,7 @@ data_check(const char *namestr, off_t regionoffset,
 
 	if (!data_matches(namestr, regionoffset,
 			  code, seq, zerostart, len, checkstart, checklen)) {
-		tprintf("ERROR: file %s range %lld-%lld contains garbage\n",
+		printf("ERROR: file %s range %lld-%lld contains garbage\n",
 		       namestr, regionoffset + checkstart,
 		       regionoffset + checkstart + checklen);
 	}

userland/testbin/frack/do.c

@@ -72,7 +72,7 @@ do_createfile(unsigned name)
 	if (fd < 0) {
 		err(1, "%s: create", namestr);
 	}
-	tprintf("create %s\n", namestr);
+	printf("create %s\n", namestr);
 	return fd;
 }
 
@@ -122,7 +122,7 @@ do_write(int fd, unsigned name, unsigned code, unsigned seq,
 		done += ret;
 	}
 
-	tprintf("write %s: %lld at %lld\n", namestr, len, pos);
+	printf("write %s: %lld at %lld\n", namestr, len, pos);
 }
 
 void
@@ -134,7 +134,7 @@ do_truncate(int fd, unsigned name, off_t len)
 	if (ftruncate(fd, len) == -1) {
 		err(1, "%s: truncate to %lld", namestr, len);
 	}
-	tprintf("truncate %s: to %lld\n", namestr, len);
+	printf("truncate %s: to %lld\n", namestr, len);
 }
 
 void
@@ -146,7 +146,7 @@ do_mkdir(unsigned name)
 	if (mkdir(namestr, 0775) == -1) {
 		err(1, "%s: mkdir", namestr);
 	}
-	tprintf("mkdir %s\n", namestr);
+	printf("mkdir %s\n", namestr);
 }
 
 void
@@ -158,7 +158,7 @@ do_rmdir(unsigned name)
 	if (rmdir(namestr) == -1) {
 		err(1, "%s: rmdir", namestr);
 	}
-	tprintf("rmdir %s\n", namestr);
+	printf("rmdir %s\n", namestr);
 }
 
 void
@@ -170,7 +170,7 @@ do_unlink(unsigned name)
 	if (remove(namestr) == -1) {
 		err(1, "%s: remove", namestr);
 	}
-	tprintf("remove %s\n", namestr);
+	printf("remove %s\n", namestr);
 }
 
 void
@@ -183,7 +183,7 @@ do_link(unsigned from, unsigned to)
 	if (link(fromstr, tostr) == -1) {
 		err(1, "link %s to %s", fromstr, tostr);
 	}
-	tprintf("link %s %s\n", fromstr, tostr);
+	printf("link %s %s\n", fromstr, tostr);
 }
 
 void
@@ -196,7 +196,7 @@ do_rename(unsigned from, unsigned to)
 	if (rename(fromstr, tostr) == -1) {
 		err(1, "rename %s to %s", fromstr, tostr);
 	}
-	tprintf("rename %s %s\n", fromstr, tostr);
+	printf("rename %s %s\n", fromstr, tostr);
 }
 
 void
@@ -216,7 +216,7 @@ do_renamexd(unsigned fromdir, unsigned from, unsigned todir, unsigned to)
 	if (rename(frombuf, tobuf) == -1) {
 		err(1, "rename %s to %s", frombuf, tobuf);
 	}
-	tprintf("rename %s %s\n", frombuf, tobuf);
+	printf("rename %s %s\n", frombuf, tobuf);
 }
 
 void
@@ -228,7 +228,7 @@ do_chdir(unsigned name)
 	if (chdir(namestr) == -1) {
 		err(1, "chdir: %s", namestr);
 	}
-	tprintf("chdir %s\n", namestr);
+	printf("chdir %s\n", namestr);
 }
 
 void
@@ -237,7 +237,7 @@ do_chdirup(void)
 	if (chdir("..") == -1) {
 		err(1, "chdir: ..");
 	}
-	tprintf("chdir ..\n");
+	printf("chdir ..\n");
 }
 
 void
@@ -246,6 +246,6 @@ do_sync(void)
 	if (sync()) {
 		warn("sync");
 	}
-	tprintf("sync\n");
-	tprintf("----------------------------------------\n");
+	printf("sync\n");
+	printf("----------------------------------------\n");
 }

userland/testbin/frack/main.c

@@ -132,13 +132,13 @@ printworkloads(void)
 {
 	unsigned i;
 
-	tprintf("Supported workloads:\n");
+	printf("Supported workloads:\n");
 	for (i=0; i<numworkloads; i++) {
-		tprintf("   %s", workloads[i].name);
+		printf("   %s", workloads[i].name);
 		if (workloads[i].argname) {
-			tprintf(" %s", workloads[i].argname);
+			printf(" %s", workloads[i].argname);
 		}
-		tprintf("\n");
+		printf("\n");
 	}
 }
 

userland/testbin/hash/hash.c

@@ -77,7 +77,7 @@ main(int argc, char *argv[])
 
 	close(fd);
 
-	tprintf("Hash : %d\n", j);
+	printf("Hash : %d\n", j);
 
 	return 0;
 }

userland/testbin/huge/huge.c

@@ -39,53 +39,45 @@
 
 #include <stdio.h>
 #include <stdlib.h>
-#include <test161/test161.h>
-#include <test/test.h>
 
 #define PageSize	4096
 #define NumPages	512
 
 int sparse[NumPages][PageSize];	/* use only the first element in the row */
 
-#define PROGRESS_INTERVAL 20
-
 int
 main(void)
 {
 	int i,j;
 
-	tprintf("Entering the huge program - I will stress test your VM\n");
+	printf("Entering the huge program - I will stress test your VM\n");
 
 	/* move number in so that sparse[i][0]=i */
 	for (i=0; i<NumPages; i++) {
-		TEST161_LPROGRESS_N(i, PROGRESS_INTERVAL);
 		sparse[i][0]=i;
 	}
 
-	lsay("\nstage [1] done\n");
+	printf("stage [1] done\n");
 
 	/* increment each location 5 times */
 	for (j=0; j<5; j++) {
 		for (i=0; i<NumPages; i++) {
-			TEST161_LPROGRESS_N(i, PROGRESS_INTERVAL);
 			sparse[i][0]++;
 		}
-		lsay("\nstage [2.%d] done\n", j);
+		printf("stage [2.%d] done\n", j);
 	}
 
-	lsay("\nstage [2] done\n");
+	printf("stage [2] done\n");
 
 	/* check if the numbers are sane */
 	for (i=NumPages-1; i>=0; i--) {
-		TEST161_LPROGRESS_N(i, PROGRESS_INTERVAL);
 		if (sparse[i][0]!=i+5) {
-			lsay("BAD NEWS!!! - your VM mechanism has a bug!\n");
-			success(TEST161_FAIL, SECRET, "/testbin/huge");
+			printf("BAD NEWS!!! - your VM mechanism has a bug!\n");
 			exit(1);
 		}
 	}
 
-	success(TEST161_SUCCESS, SECRET, "/testbin/huge");
+	printf("You passed!\n");
 
 	return 0;
 }

userland/testbin/malloctest/malloctest.c

@@ -77,7 +77,7 @@ geti(void)
 			break;
 		}
 		else if ((ch=='\b' || ch==127) && digits>0) {
-			tprintf("\b \b");
+			printf("\b \b");
 			val = val/10;
 			digits--;
 		}
@@ -117,11 +117,11 @@ markblock(volatile void *ptr, size_t size, unsigned bias, int doprint)
 		val = ((unsigned long)i ^ (unsigned long)bias);
 		pl[i] = val;
 		if (doprint && (i%64==63)) {
-			tprintf(".");
+			printf(".");
 		}
 	}
 	if (doprint) {
-		tprintf("\n");
+		printf("\n");
 	}
 }
 
@@ -143,9 +143,9 @@ checkblock(volatile void *ptr, size_t size, unsigned bias, int doprint)
 		val = ((unsigned long)i ^ (unsigned long)bias);
 		if (pl[i] != val) {
 			if (doprint) {
-				tprintf("\n");
+				printf("\n");
 			}
-			tprintf("FAILED: data mismatch at offset %lu of block "
+			printf("FAILED: data mismatch at offset %lu of block "
 			       "at 0x%lx: %lu vs. %lu\n",
 			       (unsigned long) (i*sizeof(unsigned long)),
 			       (unsigned long)(uintptr_t)pl,
@@ -153,11 +153,11 @@ checkblock(volatile void *ptr, size_t size, unsigned bias, int doprint)
 			return -1;
 		}
 		if (doprint && (i%64==63)) {
-			tprintf(".");
+			printf(".");
 		}
 	}
 	if (doprint) {
-		tprintf("\n");
+		printf("\n");
 	}
 
 	return 0;
@@ -178,23 +178,23 @@ test1(void)
 {
 	volatile unsigned *x;
 
-	tprintf("*** Malloc test 1 ***\n");
-	tprintf("Allocating %u bytes\n", BIGSIZE);
+	printf("*** Malloc test 1 ***\n");
+	printf("Allocating %u bytes\n", BIGSIZE);
 	x = malloc(BIGSIZE);
 	if (x==NULL) {
-		tprintf("FAILED: malloc failed\n");
+		printf("FAILED: malloc failed\n");
 		return;
 	}
 
 	markblock(x, BIGSIZE, 0, 0);
 	if (checkblock(x, BIGSIZE, 0, 0)) {
-		tprintf("FAILED: data corrupt\n");
+		printf("FAILED: data corrupt\n");
 		return;
 	}
 
 	free((void *)x);
 
-	tprintf("Passed malloc test 1.\n");
+	printf("Passed malloc test 1.\n");
 }
 
 
@@ -237,43 +237,43 @@ test2(void)
 	volatile unsigned *x;
 	size_t size;
 
-	tprintf("Entering malloc test 2.\n");
-	tprintf("Make sure you read and understand the comment in malloctest.c "
+	printf("Entering malloc test 2.\n");
+	printf("Make sure you read and understand the comment in malloctest.c "
 	       "that\nexplains the conditions this test assumes.\n\n");
 
-	tprintf("Testing how much memory we can allocate:\n");
+	printf("Testing how much memory we can allocate:\n");
 
 	for (size = HUGESIZE; (x = malloc(size))==NULL; size = size/2) {
-		tprintf("  %9lu bytes: failed\n", (unsigned long) size);
+		printf("  %9lu bytes: failed\n", (unsigned long) size);
 	}
-	tprintf("  %9lu bytes: succeeded\n", (unsigned long) size);
+	printf("  %9lu bytes: succeeded\n", (unsigned long) size);
 
-	tprintf("Passed part 1\n");
+	printf("Passed part 1\n");
 
-	tprintf("Touching all the words in the block.\n");
+	printf("Touching all the words in the block.\n");
 	markblock(x, size, 0, 1);
 
-	tprintf("Validating the words in the block.\n");
+	printf("Validating the words in the block.\n");
 	if (checkblock(x, size, 0, 1)) {
-		tprintf("FAILED: data corrupt\n");
+		printf("FAILED: data corrupt\n");
 		return;
 	}
-	tprintf("Passed part 2\n");
+	printf("Passed part 2\n");
 
 
-	tprintf("Freeing the block\n");
+	printf("Freeing the block\n");
 	free((void *)x);
-	tprintf("Passed part 3\n");
-	tprintf("Allocating another block\n");
+	printf("Passed part 3\n");
+	printf("Allocating another block\n");
 
 	x = malloc(size);
 	if (x==NULL) {
-		tprintf("FAILED: free didn't return the memory?\n");
+		printf("FAILED: free didn't return the memory?\n");
 		return;
 	}
 	free((void *)x);
 
-	tprintf("Passed malloc test 2.\n");
+	printf("Passed malloc test 2.\n");
 }
 
 
@@ -304,11 +304,11 @@ test3(void)
 	int ct=0, failed=0;
 	void *x;
 
-	tprintf("Entering malloc test 3.\n");
-	tprintf("Make sure you read and understand the comment in malloctest.c "
+	printf("Entering malloc test 3.\n");
+	printf("Make sure you read and understand the comment in malloctest.c "
 	       "that\nexplains the conditions this test assumes.\n\n");
 
-	tprintf("Testing how much memory we can allocate:\n");
+	printf("Testing how much memory we can allocate:\n");
 
 	while ((tmp = malloc(sizeof(struct test3))) != NULL) {
 
@@ -322,33 +322,33 @@ test3(void)
 
 		ct++;
 		if (ct%128==0) {
-			tprintf(".");
+			printf(".");
 		}
 	}
 
-	tprintf("Allocated %lu bytes\n", (unsigned long) tot);
+	printf("Allocated %lu bytes\n", (unsigned long) tot);
 
-	tprintf("Trying some more allocations which I expect to fail...\n");
+	printf("Trying some more allocations which I expect to fail...\n");
 
 	x = malloc(SMALLSIZE);
 	if (x != NULL) {
-		tprintf("FAILED: malloc(%u) succeeded\n", SMALLSIZE);
+		printf("FAILED: malloc(%u) succeeded\n", SMALLSIZE);
 		return;
 	}
 
 	x = malloc(MEDIUMSIZE);
 	if (x != NULL) {
-		tprintf("FAILED: malloc(%u) succeeded\n", MEDIUMSIZE);
+		printf("FAILED: malloc(%u) succeeded\n", MEDIUMSIZE);
 		return;
 	}
 
 	x = malloc(BIGSIZE);
 	if (x != NULL) {
-		tprintf("FAILED: malloc(%u) succeeded\n", BIGSIZE);
+		printf("FAILED: malloc(%u) succeeded\n", BIGSIZE);
 		return;
 	}
 
-	tprintf("Ok, now I'm going to free everything...\n");
+	printf("Ok, now I'm going to free everything...\n");
 
 	while (list != NULL) {
 		tmp = list->next;
@@ -363,20 +363,20 @@ test3(void)
 	}
 
 	if (failed) {
-		tprintf("FAILED: data corruption\n");
+		printf("FAILED: data corruption\n");
 		return;
 	}
 
-	tprintf("Let me see if I can allocate some more now...\n");
+	printf("Let me see if I can allocate some more now...\n");
 
 	x = malloc(MEDIUMSIZE);
 	if (x == NULL) {
-		tprintf("FAIL: Nope, I couldn't.\n");
+		printf("FAIL: Nope, I couldn't.\n");
 		return;
 	}
 	free(x);
 
-	tprintf("Passed malloc test 3\n");
+	printf("Passed malloc test 3\n");
 }
 
 ////////////////////////////////////////////////////////////
@@ -397,34 +397,34 @@ test4(void)
 	void *x, *y, *z;
 	unsigned long lx, ly, lz, overhead, zsize;
 
-	tprintf("Entering malloc test 4.\n");
-	tprintf("This test is intended for first/best-fit based mallocs.\n");
-	tprintf("This test may not work correctly if run after other tests.\n");
+	printf("Entering malloc test 4.\n");
+	printf("This test is intended for first/best-fit based mallocs.\n");
+	printf("This test may not work correctly if run after other tests.\n");
 
-	tprintf("Testing free list coalescing:\n");
+	printf("Testing free list coalescing:\n");
 
 	x = malloc(SMALLSIZE);
 	if (x==NULL) {
-		tprintf("FAILED: malloc(%u) failed\n", SMALLSIZE);
+		printf("FAILED: malloc(%u) failed\n", SMALLSIZE);
 		return;
 	}
 
 	y = malloc(MEDIUMSIZE);
 	if (y==NULL) {
-		tprintf("FAILED: malloc(%u) failed\n", MEDIUMSIZE);
+		printf("FAILED: malloc(%u) failed\n", MEDIUMSIZE);
 		return;
 	}
 
 	if (sizeof(unsigned long) < sizeof(void *)) {
-		tprintf("Buh? I can't fit a void * in an unsigned long\n");
-		tprintf("ENVIRONMENT FAILED...\n");
+		printf("Buh? I can't fit a void * in an unsigned long\n");
+		printf("ENVIRONMENT FAILED...\n");
 		return;
 	}
 
 	lx = (unsigned long)x;
 	ly = (unsigned long)y;
 
-	tprintf("x is 0x%lx; y is 0x%lx\n", lx, ly);
+	printf("x is 0x%lx; y is 0x%lx\n", lx, ly);
 
 	/*
 	 * The memory should look something like this:
@@ -436,7 +436,7 @@ test4(void)
 
 	/* This is obviously wrong. */
 	if (lx == ly) {
-		tprintf("FAIL: x == y\n");
+		printf("FAIL: x == y\n");
 		return;
 	}
 
@@ -447,11 +447,11 @@ test4(void)
 	 * or the other block's start is within the first block.)
 	 */
 	if (lx < ly && lx + SMALLSIZE > ly) {
-		tprintf("FAIL: y starts within x\n");
+		printf("FAIL: y starts within x\n");
 		return;
 	}
 	if (ly < lx && ly + MEDIUMSIZE > lx) {
-		tprintf("FAIL: x starts within y\n");
+		printf("FAIL: x starts within y\n");
 		return;
 	}
 
@@ -461,7 +461,7 @@ test4(void)
 	 * free list.
 	 */
 	if (ly < lx) {
-		tprintf("TEST UNSUITABLE: y is below x\n");
+		printf("TEST UNSUITABLE: y is below x\n");
 		return;
 	}
 
@@ -469,39 +469,39 @@ test4(void)
 	 * Compute the space used by index structures.
 	 */
 	overhead = ly - (lx + SMALLSIZE);
-	tprintf("Apparent block overhead: %lu\n", overhead);
+	printf("Apparent block overhead: %lu\n", overhead);
 
 	if (overhead > ABSURD_OVERHEAD) {
-		tprintf("TEST UNSUITABLE: block overhead absurdly large.\n");
+		printf("TEST UNSUITABLE: block overhead absurdly large.\n");
 		return;
 	}
 	if (overhead > OVERHEAD) {
-		tprintf("FAIL: block overhead is too large.\n");
+		printf("FAIL: block overhead is too large.\n");
 		return;
 	}
 
-	tprintf("Freeing blocks...\n");
+	printf("Freeing blocks...\n");
 	free(x);
 	free(y);
 
 	zsize = SMALLSIZE + MEDIUMSIZE + overhead;
 
-	tprintf("Now allocating %lu bytes... should reuse the space.\n", zsize);
+	printf("Now allocating %lu bytes... should reuse the space.\n", zsize);
 	z = malloc(zsize);
 	if (z == NULL) {
-		tprintf("FAIL: Allocation failed...\n");
+		printf("FAIL: Allocation failed...\n");
 		return;
 	}
 
 	lz = (unsigned long) z;
 
-	tprintf("z is 0x%lx (x was 0x%lx, y 0x%lx)\n", lz, lx, ly);
+	printf("z is 0x%lx (x was 0x%lx, y 0x%lx)\n", lz, lx, ly);
 
 	if (lz==lx) {
-		tprintf("Passed.\n");
+		printf("Passed.\n");
 	}
 	else {
-		tprintf("Failed.\n");
+		printf("Failed.\n");
 	}
 
 	free(z);
@@ -530,7 +530,7 @@ test567(int testno, unsigned long seed)
 	int i, n, size, failed=0;
 
 	srandom(seed);
-	tprintf("Seeded random number generator with %lu.\n", seed);
+	printf("Seeded random number generator with %lu.\n", seed);
 
 	for (i=0; i<32; i++) {
 		ptrs[i] = NULL;
@@ -544,7 +544,7 @@ test567(int testno, unsigned long seed)
 			ptrs[n] = malloc(size);
 			psizes[n] = size;
 			if (ptrs[n] == NULL) {
-				tprintf("\nmalloc %u failed\n", size);
+				printf("\nmalloc %u failed\n", size);
 				failed = 1;
 				break;
 			}
@@ -561,10 +561,10 @@ test567(int testno, unsigned long seed)
 			psizes[n] = 0;
 		}
 		if (i%256==0) {
-			tprintf(".");
+			printf(".");
 		}
 	}
-	tprintf("\n");
+	printf("\n");
 
 	for (i=0; i<32; i++) {
 		if (ptrs[i] != NULL) {
@@ -573,10 +573,10 @@ test567(int testno, unsigned long seed)
 	}
 
 	if (failed) {
-		tprintf("FAILED malloc test %d\n", testno);
+		printf("FAILED malloc test %d\n", testno);
 	}
 	else {
-		tprintf("Passed malloc test %d\n", testno);
+		printf("Passed malloc test %d\n", testno);
 	}
 }
 
@@ -584,7 +584,7 @@ static
 void
 test5(void)
 {
-	tprintf("Beginning malloc test 5\n");
+	printf("Beginning malloc test 5\n");
 	test567(5, 0);
 }
 
@@ -595,7 +595,7 @@ test6(void)
 	int fd, len;
 	unsigned long seed;
 
-	tprintf("Beginning malloc test 6\n");
+	printf("Beginning malloc test 6\n");
 
 	fd = open(_PATH_RANDOM, O_RDONLY);
 	if (fd < 0) {
@@ -619,9 +619,9 @@ test7(void)
 {
 	unsigned long seed;
 
-	tprintf("Beginning malloc test 7\n");
+	printf("Beginning malloc test 7\n");
 
-	tprintf("Enter random seed: ");
+	printf("Enter random seed: ");
 	seed = geti();
 
 	test567(7, seed);
@@ -673,12 +673,12 @@ main(int argc, char *argv[])
 	while (1) {
 		if (menu) {
 			for (i=0; tests[i].num>=0; i++) {
-				tprintf("  %2d  %s\n", tests[i].num,
+				printf("  %2d  %s\n", tests[i].num,
 				       tests[i].desc);
 			}
 			menu = 0;
 		}
-		tprintf("malloctest: ");
+		printf("malloctest: ");
 		tn = geti();
 		if (tn < 0) {
 			break;

userland/testbin/matmult/matmult-orig.c

@@ -75,14 +75,14 @@ main(void)
             for (k = 0; k < Dim; k++)
 		 C[i][j] += A[i][k] * B[k][j];
 
-    tprintf("matmult-orig finished.\n");
+    printf("matmult-orig finished.\n");
     r = C[Dim-1][Dim-1];
-    tprintf("answer is: %d (should be %d)\n", r, RIGHT);
+    printf("answer is: %d (should be %d)\n", r, RIGHT);
     if (r != RIGHT) {
-	    tprintf("FAILED\n");
+	    printf("FAILED\n");
     }
     else {
-	    tprintf("Passed.\n");
+	    printf("Passed.\n");
     }
     return 0;
 }

userland/testbin/matmult/matmult.c

@@ -41,7 +41,6 @@
 
 #include <unistd.h>
 #include <stdio.h>
-#include <test161/test161.h>
 
 #define Dim 	72	/* sum total of the arrays doesn't fit in
 			 * physical memory
@@ -59,49 +58,33 @@ main(void)
 {
     int i, j, k, r;
 
-    for (i = 0; i < Dim; i++) {		/* first initialize the matrices */
-		for (j = 0; j < Dim; j++) {
-			TEST161_LPROGRESS_N(i*Dim + j, 1000);
-			A[i][j] = i;
-			B[i][j] = j;
-			C[i][j] = 0;
-		}
+    for (i = 0; i < Dim; i++)		/* first initialize the matrices */
+	for (j = 0; j < Dim; j++) {
+	     A[i][j] = i;
+	     B[i][j] = j;
+	     C[i][j] = 0;
 	}
-	nprintf("\n");
 
-    for (i = 0; i < Dim; i++) {		/* then multiply them together */
-		for (j = 0; j < Dim; j++) {
-            for (k = 0; k < Dim; k++) {
-				TEST161_LPROGRESS_N(i*j*Dim*Dim + k, 50000);
-				T[i][j][k] = A[i][k] * B[k][j];
-			}
-		}
-	}
-	nprintf("\n");
+    for (i = 0; i < Dim; i++)		/* then multiply them together */
+	for (j = 0; j < Dim; j++)
+            for (k = 0; k < Dim; k++)
+		T[i][j][k] = A[i][k] * B[k][j];
 
-    for (i = 0; i < Dim; i++) {
-		for (j = 0; j < Dim; j++) {
-            for (k = 0; k < Dim; k++) {
-				TEST161_LPROGRESS_N(i*j*Dim*Dim + k, 50000);
-				C[i][j] += T[i][j][k];
-			}
-		}
-	}
-	nprintf("\n");
+    for (i = 0; i < Dim; i++)
+	for (j = 0; j < Dim; j++)
+            for (k = 0; k < Dim; k++)
+		C[i][j] += T[i][j][k];
 
     r = 0;
     for (i = 0; i < Dim; i++)
 	    r += C[i][i];
 
-    nprintf("matmult finished.\n");
-    nprintf("answer is: %d (should be %d)\n", r, RIGHT);
+    printf("matmult finished.\n");
+    printf("answer is: %d (should be %d)\n", r, RIGHT);
     if (r != RIGHT) {
-	    nprintf("FAILED\n");
-		success(TEST161_FAIL, SECRET, "/testbin/matmult");
+	    printf("FAILED\n");
 	    return 1;
     }
-
-    nprintf("Passed.\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/matmult");
+    printf("Passed.\n");
     return 0;
 }

userland/testbin/multiexec/multiexec.c

@@ -169,13 +169,16 @@ spawn(int njobs)
 	semcreate("1", &s1);
 	semcreate("2", &s2);
 
-	tprintf("Forking %d child processes...\n", njobs);
+	printf("Forking %d child processes...\n", njobs);
 
 	for (i=0; i<njobs; i++) {
 		pids[i] = fork();
 		if (pids[i] == -1) {
-			/* abandon the other procs; no way to kill them */
-			err(1, "fork");
+			/* continue with the procs we have; cannot kill them */
+			warn("fork");
+			warnx("*** Only started %u processes ***", i);
+			njobs = i;
+			break;
 		}
 		if (pids[i] == 0) {
 			/* child */
@@ -193,9 +196,9 @@ spawn(int njobs)
 
 	semopen(&s1);
 	semopen(&s2);
-	tprintf("Waiting for fork...\n");
+	printf("Waiting for fork...\n");
 	semP(&s1, njobs);
-	tprintf("Starting the execs...\n");
+	printf("Starting the execs...\n");
 	semV(&s2, njobs);
 
 	failed = 0;
@@ -219,7 +222,7 @@ spawn(int njobs)
 		warnx("%d children failed", failed);
 	}
 	else {
-		tprintf("Succeeded\n");
+		printf("Succeeded\n");
 	}
 
 	semclose(&s1);

userland/testbin/palin/palin.c

@@ -83,7 +83,6 @@ a canal - Panama!
 
 #include <stdio.h>
 #include <string.h>
-#include <test161/test161.h>
 
 char palindrome[8000] =
 "amanaplanacaretabanamyriadasumalacaliarahoopapintacatalpaagasanoil"
@@ -176,24 +175,24 @@ main(void)
 {
 	char *start, *end;
 
-	tprintf("Welcome to the palindrome tester!\n");
-	tprintf("I will take a large palindrome and test it.\n");
-	tprintf("Here it is:\n");
-	tprintf("%s\n", palindrome);
+	printf("Welcome to the palindrome tester!\n");
+	printf("I will take a large palindrome and test it.\n");
+	printf("Here it is:\n");
+	printf("%s\n", palindrome);
 
-	tprintf("Testing...");
+	printf("Testing...");
 	/* skip to end */
 	end = palindrome+strlen(palindrome);
 	end--;
 
 	for (start = palindrome; start <= end; start++, end--) {
+		putchar('.');
 		if (*start != *end) {
-			success(TEST161_FAIL, SECRET, "/testbin/palin");
-			tprintf("NOT a palindrome\n");
+			printf("NOT a palindrome\n");
 			return 0;
 		}
 	}
-	tprintf("IS a palindrome\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/palin");
+
+	printf("IS a palindrome\n");
 	return 0;
 }

userland/testbin/parallelvm/parallelvm.c

@@ -45,8 +45,6 @@
 #include <stdlib.h>
 #include <unistd.h>
 #include <err.h>
-#include <test/test.h>
-#include <test161/test161.h>
 
 #define NJOBS    24
 
@@ -54,8 +52,6 @@
 #define NMATS    11
 #define JOBSIZE  ((NMATS+1)*DIM*DIM*sizeof(int))
 
-#define PROGRESS_INTERVAL 25000
-
 static const int right_answers[NJOBS] = {
         -1337312809,
 	356204544,
@@ -91,20 +87,35 @@ struct matrix {
 
 ////////////////////////////////////////////////////////////
 
+/*
+ * Use this instead of just calling printf so we know each printout
+ * is atomic; this prevents the lines from getting intermingled.
+ */
+static
+void
+say(const char *fmt, ...)
+{
+	char buf[256];
+	va_list ap;
+	va_start(ap, fmt);
+	vsnprintf(buf, sizeof(buf), fmt, ap);
+	va_end(ap);
+	write(STDOUT_FILENO, buf, strlen(buf));
+}
+
+////////////////////////////////////////////////////////////
+
 static
 void
 multiply(struct matrix *res, const struct matrix *m1, const struct matrix *m2)
 {
-	int i, j, k, tot;
+	int i, j, k;
 
-	tot = 0;
 	for (i=0; i<DIM; i++) {
 		for (j=0; j<DIM; j++) {
 			int val=0;
 			for (k=0; k<DIM; k++) {
 				val += m1->m_data[i][k]*m2->m_data[k][j];
-				TEST161_LPROGRESS_N(tot, PROGRESS_INTERVAL);
-				tot++;
 			}
 			res->m_data[i][j] = val;
 		}
@@ -190,19 +201,18 @@ go(int mynum)
 {
 	int r;
 
-	lsay("Process %d (pid %d) starting computation...\n", mynum,
+	say("Process %d (pid %d) starting computation...\n", mynum,
 	    (int) getpid());
+
 	computeall(mynum);
 	r = answer();
 
 	if (r != right_answers[mynum]) {
-		tsay("Process %d answer %d: FAILED, should be %d\n",
+		say("Process %d answer %d: FAILED, should be %d\n",
 		    mynum, r, right_answers[mynum]);
-		success(TEST161_FAIL, SECRET, "/testbin/parallelvm");
 		exit(1);
 	}
-
-	lsay("\nProcess %d: OK\n", mynum, r);
+	say("Process %d answer %d: passed\n", mynum, r);
 	exit(0);
 }
 
@@ -319,8 +329,8 @@ makeprocs(bool dowait)
 		semcreate("2", &s2);
 	}
 
-	tprintf("Job size approximately %lu bytes\n", (unsigned long) JOBSIZE);
-	tprintf("Forking %d jobs; total load %luk\n", NJOBS,
+	printf("Job size approximately %lu bytes\n", (unsigned long) JOBSIZE);
+	printf("Forking %d jobs; total load %luk\n", NJOBS,
 	       (unsigned long) (NJOBS * JOBSIZE)/1024);
 
 	for (i=0; i<NJOBS; i++) {
@@ -331,7 +341,7 @@ makeprocs(bool dowait)
 		if (pids[i]==0) {
 			/* child */
 			if (dowait) {
-				//tsay("Process %d forked\n", i);
+				say("Process %d forked\n", i);
 				semopen(&s1);
 				semopen(&s2);
 				semV(&s1, 1);
@@ -346,9 +356,9 @@ makeprocs(bool dowait)
 	if (dowait) {
 		semopen(&s1);
 		semopen(&s2);
-		//tsay("Waiting for fork...\n");
+		say("Waiting for fork...\n");
 		semP(&s1, NJOBS);
-		//tsay("Starting computation.\n");
+		say("Starting computation.\n");
 		semV(&s2, NJOBS);
 	}
 
@@ -371,9 +381,7 @@ makeprocs(bool dowait)
 		printf("%d subprocesses failed\n", failcount);
 		exit(1);
 	}
-	nprintf("\n");
-	tprintf("Test complete\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/parallelvm");
+	printf("Test complete\n");
 
 	semclose(&s1);
 	semclose(&s2);
@@ -396,7 +404,7 @@ main(int argc, char *argv[])
 		dowait = true;
 	}
 	else {
-		tprintf("Usage: parallelvm [-w]\n");
+		printf("Usage: parallelvm [-w]\n");
 		return 1;
 	}
 	makeprocs(dowait);

userland/testbin/randcall/gencalls.sh

@@ -34,7 +34,6 @@ awk < $1 '
 	printf "#include <stdlib.h>\n";
 	printf "#include <errno.h>\n";
 	printf "#include <err.h>\n";
-	printf "#include <test161/test161.h>\n";
 	printf "\n";
 	printf "#include \"extern.h\"\n";
 	printf "\n";
@@ -68,7 +67,7 @@ awk < $1 '
 	    if (i<NF) printf ", ";
 	}
 	printf ");\n";
-	printf"\ttprintf(\"%%-47s\", buf);\n";
+	printf"\tprintf(\"%%-47s\", buf);\n";
 	#printf "\tfflush(stdout);\n";
 	printf "\n";
 
@@ -89,7 +88,7 @@ awk < $1 '
 	}
 	printf ");\n";
 
-	printf "\ttprintf(\" result %%d, errno %%d\\n\", result, errno);\n";
+	printf "\tprintf(\" result %%d, errno %%d\\n\", result, errno);\n";
 	printf "\tif (dofork) {\n";
 	printf "\t\texit(0);\n";
 	printf "\t}\n";
@@ -135,11 +134,9 @@ awk < $1 '
 
 	printf "\tfor (i=0; i<count; i++) {\n";
 	printf "\t\tfor (j=0; list[j]; j++) {\n";
-	printf "\t\t\tnprintf(\".\");\n";
 	printf "\t\t\t(*list[j])(dofork);\n";
 	printf "\t\t}\n";
 	printf "\t}\n";
-	printf "nprintf(\"\\n\");\n";
 	printf "}\n";
 	printf "\n";
     }

userland/testbin/randcall/main.c

@@ -30,7 +30,6 @@
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
-#include <test161/test161.h>
 
 #include "extern.h"
 
@@ -114,10 +113,10 @@ static
 void
 usage(void)
 {
-	tprintf("Usage: randcall [-f] [-c count] [-r seed] 2|3|4|all\n");
-	tprintf("   -f   suppress forking\n");
-	tprintf("   -c   set iteration count (default 100)\n");
-	tprintf("   -r   set pseudorandom seed (default 0)\n");
+	printf("Usage: randcall [-f] [-c count] [-r seed] 2|3|4|all\n");
+	printf("   -f   suppress forking\n");
+	printf("   -c   set iteration count (default 100)\n");
+	printf("   -r   set pseudorandom seed (default 0)\n");
 	exit(1);
 }
 
@@ -158,11 +157,10 @@ main(int argc, char *argv[])
 		}
 	}
 
-	tprintf("Seed: %d  Count: %d\n", seed, count);
+	printf("Seed: %d  Count: %d\n", seed, count);
 
 	srandom(seed);
 	trycalls(an, dofork, count);
 
-	success(TEST161_SUCCESS, SECRET, "/testbin/randcall");
 	return 0;
 }

userland/testbin/redirect/redirect.c

@@ -43,7 +43,6 @@
 #include <string.h>
 #include <unistd.h>
 #include <err.h>
-#include <test161/test161.h>
 
 #define PATH_CAT "/bin/cat"
 #define INFILE "redirect.in"
@@ -182,23 +181,16 @@ cat(void)
 int
 main(void)
 {
-	tprintf("Creating %s...\n", INFILE);
+	printf("Creating %s...\n", INFILE);
 	mkfile();
-	nprintf(".");
 
-	tprintf("Running cat < %s > %s\n", INFILE, OUTFILE);
+	printf("Running cat < %s > %s\n", INFILE, OUTFILE);
 	cat();
-	nprintf(".");
 
-	tprintf("Checking %s...\n", OUTFILE);
+	printf("Checking %s...\n", OUTFILE);
 	chkfile();
-	nprintf(".");
 
-	tprintf("Passed.\n");
-	nprintf(".");
-	nprintf("\n");
-
-	success(TEST161_SUCCESS, SECRET, "/testbin/redirect");
+	printf("Passed.\n");
 	(void)remove(INFILE);
 	(void)remove(OUTFILE);
 	return 0;

userland/testbin/rmdirtest/rmdirtest.c

@@ -116,13 +116,13 @@ static
 void
 test1(void)
 {
-	tprintf("Making %s\n", testdir);
+	printf("Making %s\n", testdir);
 	startup();
 
-	tprintf("Removing %s while in it\n", testdir);
+	printf("Removing %s while in it\n", testdir);
 	killdir();
 
-	tprintf("Leaving the test directory\n");
+	printf("Leaving the test directory\n");
 	finish();
 }
 
@@ -136,7 +136,7 @@ test2(void)
 {
 	int fd;
 
-	tprintf("Now trying with the directory open...\n");
+	printf("Now trying with the directory open...\n");
 	startup();
 	fd = open(".", O_RDONLY);
 	if (fd<0) {
@@ -162,7 +162,7 @@ test3(void)
 	char buf[PATH_MAX];
 	int fd;
 
-	tprintf("Checking if . exists after rmdir\n");
+	printf("Checking if . exists after rmdir\n");
 	startup();
 	killdir();
 
@@ -230,7 +230,7 @@ test4(void)
 	char buf[4096];
 	int fd;
 
-	tprintf("Checking if creating files works after rmdir...\n");
+	printf("Checking if creating files works after rmdir...\n");
 	startup();
 	killdir();
 
@@ -272,7 +272,7 @@ static
 void
 test5(void)
 {
-	tprintf("Checking if creating subdirs works after rmdir...\n");
+	printf("Checking if creating subdirs works after rmdir...\n");
 	startup();
 	killdir();
 
@@ -315,7 +315,7 @@ test6(void)
 	char buf[PATH_MAX];
 	int fd, len;
 
-	tprintf("Now trying to list the directory...\n");
+	printf("Now trying to list the directory...\n");
 	startup();
 	fd = open(".", O_RDONLY);
 	if (fd<0) {
@@ -399,6 +399,6 @@ main(void)
 	test6();
 	test7();
 
-	tprintf("Whew... survived.\n");
+	printf("Whew... survived.\n");
 	return 0;
 }

userland/testbin/rmtest/rmtest.c

@@ -157,7 +157,7 @@ main(void)
 		err(1, "Unexpected error reopening the file");
 	}
 
-	tprintf("Succeeded!\n");
+	printf("Succeeded!\n");
 
 	return 0;
 }

userland/testbin/sbrktest/sbrktest.c

@@ -35,7 +35,6 @@
 #include <unistd.h>
 #include <err.h>
 #include <errno.h>
-#include <test161/test161.h>
 
 #define _PATH_RANDOM   "random:"
 
@@ -63,7 +62,7 @@ geti(void)
 			break;
 		}
 		else if ((ch=='\b' || ch==127) && digits>0) {
-			tprintf("\b \b");
+			printf("\b \b");
 			val = val/10;
 			digits--;
 		}
@@ -142,7 +141,7 @@ static
 void
 say(const char *msg)
 {
-	/* Use one write so it's atomic (tprintf usually won't be) */
+	/* Use one write so it's atomic (printf usually won't be) */
 	write(STDOUT_FILENO, msg, strlen(msg));
 }
 
@@ -195,9 +194,9 @@ checkpage(volatile void *baseptr, unsigned pageoffset, bool neednl)
 		val = ((unsigned long)i ^ (unsigned long)pageoffset);
 		if (pl[i] != val) {
 			if (neednl) {
-				tprintf("\n");
+				printf("\n");
 			}
-			tprintf("FAILED: data mismatch at offset %lu of page "
+			printf("FAILED: data mismatch at offset %lu of page "
 			       "at 0x%lx: %lu vs. %lu\n",
 			       (unsigned long) (i*sizeof(unsigned long)),
 			       (unsigned long)(uintptr_t)pl,
@@ -242,9 +241,9 @@ checkpagelight(volatile void *baseptr, unsigned pageoffset, bool neednl)
 	pl = (volatile unsigned long *)pageptr;
 	if (pl[0] != pageoffset) {
 		if (neednl) {
-			tprintf("\n");
+			printf("\n");
 		}
-		tprintf("FAILED: data mismatch at offset 0 of page "
+		printf("FAILED: data mismatch at offset 0 of page "
 		       "at 0x%lx: %lu vs. %u\n",
 		       (unsigned long)(uintptr_t)pl,
 		       pl[0], pageoffset);
@@ -272,37 +271,6 @@ dosbrk(ssize_t size)
 	return p;
 }
 
-////////////////////////////////////////////////////////////
-// fork a child that segfaults
-
-typedef void (*segfault_fn)(void);
-
-static
-void
-expect_segfault(segfault_fn func)
-{
-	int status;
-	int result;
-	pid_t pid = dofork();
-
-	if (pid == 0) {
-		func();	// This exits
-	} else {
-		result = waitpid(pid, &status, 0);
-		if (result == -1) {
-			err(1, "waitpid");
-		}
-		else if (WIFSIGNALED(status)) {
-			if (WTERMSIG(status) != 11) {
-				errx(1, "child: Signal %d", WTERMSIG(status));
-			}
-		}
-		else  {
-			errx(1, "child exited, expected segfault");
-		}
-	}
-}
-
 ////////////////////////////////////////////////////////////
 // align the heap
 
@@ -349,13 +317,14 @@ test1(void)
 {
 	void *p;
 
-	tprintf("Allocating a page...\n");
+	printf("Allocating a page...\n");
 	p = dosbrk(PAGE_SIZE);
 	markpage(p, 0);
 	if (checkpage(p, 0, false)) {
 		errx(1, "FAILED: data corrupt");
 	}
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+
+	printf("Passed sbrk test 1.\n");
 }
 
 /*
@@ -369,7 +338,7 @@ test2(void)
 
 	op = dosbrk(0);
 
-	tprintf("Allocating a page...\n");
+	printf("Allocating a page...\n");
 	p = dosbrk(PAGE_SIZE);
 	if (p != op) {
 		errx(1, "FAILED: sbrk grow didn't return the old break "
@@ -382,7 +351,7 @@ test2(void)
 
 	p = dosbrk(0);
 
-	tprintf("Freeing the page...\n");
+	printf("Freeing the page...\n");
 	q = dosbrk(-PAGE_SIZE);
 	if (q != p) {
 		errx(1, "FAILED: sbrk shrink didn't return the old break "
@@ -393,7 +362,8 @@ test2(void)
 		errx(1, "FAILED: sbrk shrink didn't restore the heap "
 		     "(got %p, expected %p", q, op);
 	}
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+
+	printf("Passed sbrk test 2.\n");
 }
 
 /*
@@ -412,7 +382,7 @@ test3(void)
 
 	op = dosbrk(0);
 
-	tprintf("Allocating %u pages...\n", num);
+	printf("Allocating %u pages...\n", num);
 	p = dosbrk(PAGE_SIZE * num);
 	if (p != op) {
 		errx(1, "FAILED: sbrk grow didn't return the old break "
@@ -433,7 +403,7 @@ test3(void)
 
 	p = dosbrk(0);
 
-	tprintf("Freeing the pages...\n");
+	printf("Freeing the pages...\n");
 	q = dosbrk(-PAGE_SIZE * num);
 	if (q != p) {
 		errx(1, "FAILED: sbrk shrink didn't return the old break "
@@ -444,7 +414,8 @@ test3(void)
 		errx(1, "FAILED: sbrk shrink didn't restore the heap "
 		     "(got %p, expected %p", q, op);
 	}
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+
+	printf("Passed sbrk test 3.\n");
 }
 
 /*
@@ -464,7 +435,7 @@ test4(void)
 
 	op = dosbrk(0);
 
-	tprintf("Allocating %u pages...\n", num);
+	printf("Allocating %u pages...\n", num);
 	p = dosbrk(PAGE_SIZE * num);
 	if (p != op) {
 		errx(1, "FAILED: sbrk grow didn't return the old break "
@@ -483,7 +454,7 @@ test4(void)
 		exit(1);
 	}
 
-	tprintf("Freeing the pages one at a time...\n");
+	printf("Freeing the pages one at a time...\n");
 	for (i=num; i-- > 0; ) {
 		(void)dosbrk(-PAGE_SIZE);
 		for (j=0; j<i; j++) {
@@ -503,7 +474,8 @@ test4(void)
 		errx(1, "FAILED: sbrk shrink didn't restore the heap "
 		     "(got %p, expected %p", q, op);
 	}
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+
+	printf("Passed sbrk test 4.\n");
 }
 
 ////////////////////////////////////////////////////////////
@@ -515,75 +487,51 @@ test4(void)
  */
 static
 void
-test5_helper(void)
+test5(void)
 {
 	void *p;
 
 	p = dosbrk(0);
-	tprintf("This should produce fatal signal 11 (SIGSEGV).\n");
+	printf("This should produce fatal signal 11 (SIGSEGV).\n");
 	((long *)p)[10] = 0;
 	errx(1, "FAILED: I didn't crash");
 }
 
-static
-void
-test5(void)
-{
-	expect_segfault(test5_helper);
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
-}
-
 /*
  * Allocates a page and checks that the next page past it is not
  * valid. (Crashes when successful.)
  */
 static
 void
-test6_helper(void)
+test6(void)
 {
 	void *p;
 
 	(void)dosbrk(PAGE_SIZE);
 	p = dosbrk(0);
-	tprintf("This should produce fatal signal 11 (SIGSEGV).\n");
+	printf("This should produce fatal signal 11 (SIGSEGV).\n");
 	((long *)p)[10] = 0;
 	errx(1, "FAILED: I didn't crash");
 }
 
-static
-void
-test6(void)
-{
-	expect_segfault(test6_helper);
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
-}
-
 /*
  * Allocates and frees a page and checks that the page freed is no
  * longer valid. (Crashes when successful.)
  */
 static
 void
-test7_helper(void)
+test7(void)
 {
 	void *p;
 
 	(void)dosbrk(PAGE_SIZE);
 	(void)dosbrk(-PAGE_SIZE);
 	p = dosbrk(0);
-	tprintf("This should produce fatal signal 11 (SIGSEGV).\n");
+	printf("This should produce fatal signal 11 (SIGSEGV).\n");
 	((long *)p)[10] = 0;
 	errx(1, "FAILED: I didn't crash");
 }
 
-static
-void
-test7(void)
-{
-	expect_segfault(test7_helper);
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
-}
-
 /*
  * Allocates some pages, frees half of them, and checks that the page
  * past the new end of the heap is no longer valid. (Crashes when
@@ -591,26 +539,18 @@ test7(void)
  */
 static
 void
-test8_helper(void)
+test8(void)
 {
 	void *p;
 
 	(void)dosbrk(PAGE_SIZE * 12);
 	(void)dosbrk(-PAGE_SIZE * 6);
 	p = dosbrk(0);
-	tprintf("This should produce fatal signal 11 (SIGSEGV).\n");
+	printf("This should produce fatal signal 11 (SIGSEGV).\n");
 	((long *)p)[10] = 0;
 	errx(1, "FAILED: I didn't crash");
 }
 
-static
-void
-test8(void)
-{
-	expect_segfault(test8_helper);
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
-}
-
 ////////////////////////////////////////////////////////////
 // heap size
 
@@ -648,38 +588,38 @@ test9(void)
 
 #define HUGESIZE (1024 * 1024 * 1024)	/* 1G */
 
-	tprintf("Checking how much memory we can allocate:\n");
+	printf("Checking how much memory we can allocate:\n");
 	for (size = HUGESIZE; (p = sbrk(size)) == (void *)-1; size = size/2) {
-		tprintf("  %9lu bytes: failed\n", (unsigned long) size);
+		printf("  %9lu bytes: failed\n", (unsigned long) size);
 	}
-	tprintf("  %9lu bytes: succeeded\n", (unsigned long) size);
-	tprintf("Passed sbrk test 9 (part 1/5)\n");
+	printf("  %9lu bytes: succeeded\n", (unsigned long) size);
+	printf("Passed sbrk test 9 (part 1/5)\n");
 
-	tprintf("Touching each page.\n");
+	printf("Touching each page.\n");
 	pages = size / PAGE_SIZE;
 	dot = pages / 64;
 	for (i=0; i<pages; i++) {
 		markpagelight(p, i);
-		if (dot > 0) {
-			TEST161_LPROGRESS_N(i, dot);
+		if (dot > 0 && i % dot == 0) {
+			printf(".");
 		}
 	}
 	if (dot > 0) {
 		printf("\n");
 	}
 
-	tprintf("Testing each page.\n");
+	printf("Testing each page.\n");
 	bad = false;
 	for (i=0; i<pages; i++) {
 		if (checkpagelight(p, i, dot > 0)) {
 			if (dot > 0) {
-				tprintf("\n");
+				printf("\n");
 			}
 			warnx("FAILED: data corrupt");
 			bad = true;
 		}
-		if (dot > 0) {
-			TEST161_LPROGRESS_N(i, dot);
+		if (dot > 0 && i % dot == 0) {
+			printf(".");
 		}
 	}
 	if (dot > 0) {
@@ -688,20 +628,19 @@ test9(void)
 	if (bad) {
 		exit(1);
 	}
-	tprintf("Passed sbrk test 9 (part 2/5)\n");
+	printf("Passed sbrk test 9 (part 2/5)\n");
 
-	tprintf("Freeing the memory.\n");
+	printf("Freeing the memory.\n");
 	(void)dosbrk(-size);
-	tprintf("Passed sbrk test 9 (part 3/5)\n");
+	printf("Passed sbrk test 9 (part 3/5)\n");
 
-	tprintf("Allocating the memory again.\n");
+	printf("Allocating the memory again.\n");
 	(void)dosbrk(size);
-	tprintf("Passed sbrk test 9 (part 4/5)\n");
+	printf("Passed sbrk test 9 (part 4/5)\n");
 
-	tprintf("And really freeing it.\n");
+	printf("And really freeing it.\n");
 	(void)dosbrk(-size);
-	tprintf("Passed sbrk test 9 (all)\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+	printf("Passed sbrk test 9 (all)\n");
 }
 
 /*
@@ -716,16 +655,16 @@ test10(void)
 	unsigned i, n;
 	bool bad;
 
-	tprintf("Allocating all of memory one page at a time:\n");
+	printf("Allocating all of memory one page at a time:\n");
 	op = dosbrk(0);
 	n = 0;
 	while ((p = sbrk(PAGE_SIZE)) != (void *)-1) {
 		markpagelight(op, n);
 		n++;
 	}
-	tprintf("Got %u pages (%zu bytes).\n", n, (size_t)PAGE_SIZE * n);
+	printf("Got %u pages (%zu bytes).\n", n, (size_t)PAGE_SIZE * n);
 
-	tprintf("Now freeing them.\n");
+	printf("Now freeing them.\n");
 	bad = false;
 	for (i=0; i<n; i++) {
 		if (checkpagelight(op, n - i - 1, false)) {
@@ -737,14 +676,14 @@ test10(void)
 	if (bad) {
 		exit(1);
 	}
-	tprintf("Freed %u pages.\n", n);
+	printf("Freed %u pages.\n", n);
 
 	p = dosbrk(0);
 	if (p != op) {
 		errx(1, "FAILURE: break did not return to original value");
 	}
 
-	tprintf("Now let's see if I can allocate another page.\n");
+	printf("Now let's see if I can allocate another page.\n");
 	p = dosbrk(PAGE_SIZE);
 	markpage(p, 0);
 	if (checkpage(p, 0, false)) {
@@ -752,8 +691,7 @@ test10(void)
 	}
 	(void)dosbrk(-PAGE_SIZE);
 
-	tprintf("Passed sbrk test 10.\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+	printf("Passed sbrk test 10.\n");
 }
 
 ////////////////////////////////////////////////////////////
@@ -769,34 +707,37 @@ test11(void)
 	unsigned i;
 	bool bad;
 
-	tprintf("Allocating %u pages (%zu bytes).\n", num,
+	printf("Allocating %u pages (%zu bytes).\n", num,
 	       (size_t)PAGE_SIZE * num);
 	p = dosbrk(num * PAGE_SIZE);
 
-	tprintf("Touching the pages.\n");
+	printf("Touching the pages.\n");
 	for (i=0; i<num; i++) {
 		markpagelight(p, i);
-		TEST161_LPROGRESS_N(i, 4);
+		if (i % 4 == 0) {
+			printf(".");
+		}
 	}
-	tprintf("\n");
+	printf("\n");
 
-	tprintf("Checking the pages.\n");
+	printf("Checking the pages.\n");
 	bad = false;
 	for (i=0; i<num; i++) {
 		if (checkpagelight(p, i, true)) {
 			warnx("FAILED: data corrupt");
 			bad = true;
 		}
-		TEST161_LPROGRESS_N(i, 4);
+		if (i % 4 == 0) {
+			printf(".");
+		}
 	}
 	printf("\n");
 	if (bad) {
 		exit(1);
 	}
 
-	tprintf("Now NOT freeing the pages. They should get freed on exit.\n");
-	tprintf("If not, you'll notice pretty quickly.\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+	printf("Now NOT freeing the pages. They should get freed on exit.\n");
+	printf("If not, you'll notice pretty quickly.\n");
 }
 
 ////////////////////////////////////////////////////////////
@@ -815,7 +756,7 @@ test12(void)
 	pid_t pid;
 	void *p;
 
-	tprintf("Forking...\n");
+	printf("Forking...\n");
 	pid = dofork();
 	if (pid == 0) {
 		/* child */
@@ -837,8 +778,7 @@ test12(void)
 	}
 	say("Parent done.\n");
 	dowait(pid);
-	tprintf("Passed sbrk test 12.\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+	printf("Passed sbrk test 12.\n");
 }
 
 /*
@@ -851,14 +791,14 @@ test13(void)
 	pid_t pid;
 	void *p;
 
-	tprintf("Allocating a page...\n");
+	printf("Allocating a page...\n");
 	p = dosbrk(PAGE_SIZE);
 	markpage(p, 0);
 	if (checkpage(p, 0, false)) {
 		errx(1, "FAILED: data corrupt before forking");
 	}
 
-	tprintf("Forking...\n");
+	printf("Forking...\n");
 	pid = dofork();
 	if (pid == 0) {
 		/* child */
@@ -871,8 +811,7 @@ test13(void)
 		errx(1, "FAILED: data corrupt in parent");
 	}
 	dowait(pid);
-	tprintf("Passed sbrk test 13.\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+	printf("Passed sbrk test 13.\n");
 }
 
 /*
@@ -885,21 +824,21 @@ test14(void)
 	pid_t pid;
 	void *p;
 
-	tprintf("Allocating a page...\n");
+	printf("Allocating a page...\n");
 	p = dosbrk(PAGE_SIZE);
 	markpage(p, 0);
 	if (checkpage(p, 0, false)) {
 		errx(1, "FAILED: data corrupt before forking");
 	}
 
-	tprintf("Forking...\n");
+	printf("Forking...\n");
 	pid = dofork();
 	if (pid == 0) {
 		/* child */
 		if (checkpage(p, 0, false)) {
 			errx(1, "FAILED: data corrupt in child");
 		}
-		tprintf("Child freeing a page...\n");
+		printf("Child freeing a page...\n");
 		dosbrk(-PAGE_SIZE);
 		exit(0);
 	}
@@ -907,8 +846,7 @@ test14(void)
 	if (checkpage(p, 0, false)) {
 		errx(1, "FAILED: data corrupt in parent after child ran");
 	}
-	tprintf("Passed sbrk test 14.\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+	printf("Passed sbrk test 14.\n");
 }
 
 /*
@@ -925,7 +863,7 @@ test15(void)
 	unsigned i;
 	void *p;
 
-	tprintf("Allocating %u pages...\n", num);
+	printf("Allocating %u pages...\n", num);
 	p = dosbrk(PAGE_SIZE * num);
 	for (i=0; i<num; i++) {
 		markpage(p, i);
@@ -936,7 +874,7 @@ test15(void)
 		}
 	}
 
-	tprintf("Freeing one page...\n");
+	printf("Freeing one page...\n");
 	(void)dosbrk(-PAGE_SIZE);
 	num--;
 	for (i=0; i<num; i++) {
@@ -945,7 +883,7 @@ test15(void)
 		}
 	}
 
-	tprintf("Allocating two pages...\n");
+	printf("Allocating two pages...\n");
 	(void)dosbrk(PAGE_SIZE * 2);
 	markpage(p, num++);
 	markpage(p, num++);
@@ -955,7 +893,7 @@ test15(void)
 		}
 	}
 
-	tprintf("Forking...\n");
+	printf("Forking...\n");
 	pid = dofork();
 	if (pid == 0) {
 		/* child */
@@ -1009,9 +947,7 @@ test15(void)
 	}
 
 	(void)dosbrk(-PAGE_SIZE * num);
-	tprintf("Passed sbrk test 15.\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
-
+	printf("Passed sbrk test 15.\n");
 }
 
 ////////////////////////////////////////////////////////////
@@ -1031,7 +967,7 @@ stresstest(unsigned long seed, bool large)
 	bool bad, neg;
 
 	srandom(seed);
-	tprintf("Seeded random number generator with %lu.\n", seed);
+	printf("Seeded random number generator with %lu.\n", seed);
 
 	op = dosbrk(0);
 
@@ -1063,12 +999,14 @@ stresstest(unsigned long seed, bool large)
 		}
 		for (j=0; j<num; j++) {
 			if (checkpagelight(op, j, true)) {
-				tprintf("\n");
+				printf("\n");
 				warnx("FAILED: data corrupt on page %u", j);
 				bad = true;
 			}
 		}
-		TEST161_LPROGRESS_N(i, dot);
+		if (i % dot == 0) {
+			printf(".");
+		}
 	}
 	printf("\n");
 	if (bad) {
@@ -1077,8 +1015,7 @@ stresstest(unsigned long seed, bool large)
 	}
 
 	dosbrk(-(num * PAGE_SIZE));
-	tprintf("Passed sbrk %s stress test.\n", large ? "large" : "small");
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
+	printf("Passed sbrk %s stress test.\n", large ? "large" : "small");
 }
 
 static
@@ -1099,7 +1036,7 @@ static
 void
 test18(void)
 {
-	tprintf("Enter random seed: ");
+	printf("Enter random seed: ");
 	stresstest(geti(), false);
 }
 
@@ -1121,65 +1058,10 @@ static
 void
 test21(void)
 {
-	tprintf("Enter random seed: ");
+	printf("Enter random seed: ");
 	stresstest(geti(), true);
 }
 
-static
-void
-test22(void)
-{
-	int i;
-	void *p, *q;
-	int num = 10;
-	int num_pages = 5 * 1024;	// 20MB
-
-	p = dosbrk(num_pages * PAGE_SIZE);
-	q = dosbrk(0);
-
-	if ((unsigned int)q - (unsigned int)p != (unsigned int)(num_pages*PAGE_SIZE)) {
-		errx(1, "Heap size not equal to expected size: p=0x%x q=0x%x", (unsigned int)p, (unsigned int)q);
-	}
-
-	// Just touch the last 10 pages
-	for (i = 0; i < num; i++) {
-		markpage(p, num_pages-(i+1));
-	}
-
-	// Check the last 10 pages
-	for (i = 0; i < num; i++) {
-		if (checkpage(p, num_pages-(i+1), false)) {
-			errx(1, "FAILED: data corrupt");
-		}
-	}
-
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
-}
-
-static
-void
-test23(void)
-{
-	// Make sure sbrk is freeing memory. This allocates, in total, just over 4M
-	// of memory, but moves the heap breakpoint in such a way that only one page
-	// should ever be required. This test doesn't make much sense to run with
-	// more than 4M or with swap enabled.
-	void *start;
-	int num_pages = 1030;
-	int num;
-
-	start = dosbrk(PAGE_SIZE);
-
-	for (num = 1; num <= num_pages; num++) {
-		TEST161_LPROGRESS(num);
-		start = dosbrk(num*PAGE_SIZE);
-		markpagelight(start, num-1);
-		checkpagelight(start, num-1, true);
-		dosbrk(-(num*PAGE_SIZE));
-	}
-	success(TEST161_SUCCESS, SECRET, "/testbin/sbrktest");
-}
-
 ////////////////////////////////////////////////////////////
 // main
 
@@ -1209,8 +1091,6 @@ static const struct {
 	{ 19, "Large stress test", test19 },
 	{ 20, "Randomized large stress test", test20 },
 	{ 21, "Large stress test with particular seed", test21 },
-	{ 22, "Large sbrk test", test22 },
-	{ 23, "Allocate 4MB in total, but free pages in between", test23 },
 };
 static const unsigned numtests = sizeof(tests) / sizeof(tests[0]);
 
@@ -1248,12 +1128,12 @@ main(int argc, char *argv[])
 	while (1) {
 		if (menu) {
 			for (j=0; j<numtests; j++) {
-				tprintf("  %2d  %s\n", tests[j].num,
+				printf("  %2d  %s\n", tests[j].num,
 				       tests[j].desc);
 			}
 			menu = false;
 		}
-		tprintf("sbrktest: ");
+		printf("sbrktest: ");
 		tn = geti();
 		if (tn < 0) {
 			break;

userland/testbin/schedpong/main.c

@@ -229,7 +229,7 @@ runit(unsigned numthinkers, unsigned numgrinders,
 	char buf[32];
 	unsigned i;
 
-	tprintf("Running with %u thinkers, %u grinders, and %u pong groups "
+	printf("Running with %u thinkers, %u grinders, and %u pong groups "
 	       "of size %u each.\n", numthinkers, numgrinders, numponggroups,
 	       ponggroupsize);
 
@@ -242,7 +242,7 @@ runit(unsigned numthinkers, unsigned numgrinders,
 		       &pids[i+2]);
 	}
 	usem_open(&startsem);
-	tprintf("Forking done; starting the workload.\n");
+	printf("Forking done; starting the workload.\n");
 	__time(&startsecs, &startnsecs);
 	Vn(&startsem, numthinkers + numgrinders +
 	   numponggroups * ponggroupsize);
@@ -252,20 +252,20 @@ runit(unsigned numthinkers, unsigned numgrinders,
 
 	openresultsfile(O_RDONLY);
 
-	tprintf("--- Timings ---\n");
+	printf("--- Timings ---\n");
 	if (numthinkers > 0) {
 		calcresult(0, startsecs, startnsecs, buf, sizeof(buf));
-		tprintf("Thinkers: %s\n", buf);
+		printf("Thinkers: %s\n", buf);
 	}
 
 	if (numgrinders > 0) {
 		calcresult(1, startsecs, startnsecs, buf, sizeof(buf));
-		tprintf("Grinders: %s\n", buf);
+		printf("Grinders: %s\n", buf);
 	}
 
 	for (i=0; i<numponggroups; i++) {
 		calcresult(i+2, startsecs, startnsecs, buf, sizeof(buf));
-		tprintf("Pong group %u: %s\n", i, buf);
+		printf("Pong group %u: %s\n", i, buf);
 	}
 
 	closeresultsfile();

userland/testbin/schedpong/pong.c

@@ -100,7 +100,7 @@ pong_cyclic(unsigned id)
 			P(&sems[id]);
 		}
 #ifdef VERBOSE_PONG
-		tprintf(" %u", id);
+		printf(" %u", id);
 #else
 		if (nextid == 0 && i % 16 == 0) {
 			putchar('.');
@@ -151,7 +151,7 @@ pong_reciprocating(unsigned id)
 			P(&sems[id]);
 		}
 #ifdef VERBOSE_PONG
-		tprintf(" %u", id);
+		printf(" %u", id);
 #else
 		if (id == 0 && i % 16 == 0) {
 			putchar('.');
@@ -197,11 +197,11 @@ pong(unsigned groupid, unsigned id)
 	waitstart();
 	pong_cyclic(id);
 #ifdef VERBOSE_PONG
-	tprintf("--------------------------------\n");
+	printf("--------------------------------\n");
 #endif
 	pong_reciprocating(id);
 #ifdef VERBOSE_PONG
-	tprintf("--------------------------------\n");
+	printf("--------------------------------\n");
 #endif
 	pong_cyclic(id);
 

userland/testbin/sort/sort.c

@@ -35,17 +35,14 @@
  *    Once the virtual memory assignment is complete, your system
  *    should survive this.
  */
-#include <stdint.h>
+
 #include <stdlib.h>
 #include <string.h>
 #include <err.h>
-#include <test161/test161.h>
 
 /* Larger than physical memory */
 #define SIZE  (144*1024)
 
-#define PROGRESS_INTERVAL 8000
-#define NEWLINE_FREQ 100
 
 /*
  * Quicksort.
@@ -57,61 +54,6 @@
  * Also, quicksort has somewhat more interesting memory usage patterns.
  */
 
-static unsigned iters;
-
-static inline
-void
-progress() {
-	TEST161_LPROGRESS_N(iters, PROGRESS_INTERVAL);
-	if (iters > 0 && (iters % (PROGRESS_INTERVAL * NEWLINE_FREQ)) == 0) {
-		printf("\n");
-	}
-	++iters;
-}
-
-static void *
-local_memcpy(void *dst, const void *src, size_t len)
-{
-	size_t i;
-
-	/*
-	 * memcpy does not support overlapping buffers, so always do it
-	 * forwards. (Don't change this without adjusting memmove.)
-	 *
-	 * For speedy copying, optimize the common case where both pointers
-	 * and the length are word-aligned, and copy word-at-a-time instead
-	 * of byte-at-a-time. Otherwise, copy by bytes.
-	 *
-	 * The alignment logic below should be portable. We rely on
-	 * the compiler to be reasonably intelligent about optimizing
-	 * the divides and modulos out. Fortunately, it is.
-	 */
-
-	if ((uintptr_t)dst % sizeof(long) == 0 &&
-	    (uintptr_t)src % sizeof(long) == 0 &&
-	    len % sizeof(long) == 0) {
-
-		long *d = dst;
-		const long *s = src;
-
-		for (i=0; i<len/sizeof(long); i++) {
-			progress();
-			d[i] = s[i];
-		}
-	}
-	else {
-		char *d = dst;
-		const char *s = src;
-
-		for (i=0; i<len; i++) {
-			progress();
-			d[i] = s[i];
-		}
-	}
-
-	return dst;
-}
-
 static
 void
 sort(int *arr, int size)
@@ -131,7 +73,6 @@ sort(int *arr, int size)
 	j = pivot;
 	k = 0;
 	while (i<pivot && j<size) {
-		progress();
 		if (arr[i] < arr[j]) {
 			tmp[k++] = arr[i++];
 		}
@@ -140,15 +81,13 @@ sort(int *arr, int size)
 		}
 	}
 	while (i<pivot) {
-		progress();
 		tmp[k++] = arr[i++];
 	}
 	while (j<size) {
-		progress();
 		tmp[k++] = arr[j++];
 	}
 
-	local_memcpy(arr, tmp, size*sizeof(int));
+	memcpy(arr, tmp, size*sizeof(int));
 }
 
 ////////////////////////////////////////////////////////////
@@ -177,15 +116,13 @@ check(void)
 {
 	int i;
 
-	printf("\nChecking...");
 	for (i=0; i<SIZE-1; i++) {
-		TEST161_LPROGRESS_N(i, PROGRESS_INTERVAL);
 		if (A[i] > A[i+1]) {
 			errx(1, "Failed: A[%d] is %d, A[%d] is %d",
 			     i, A[i], i+1, A[i+1]);
 		}
 	}
-	success(TEST161_SUCCESS, SECRET, "/testbin/sort");
+	warnx("Passed.");
 }
 
 int

userland/testbin/sparsefile/sparsefile.c

@@ -41,8 +41,6 @@
 #include <unistd.h>
 #include <fcntl.h>
 #include <err.h>
-#include <string.h>
-#include <test161/test161.h>
 
 int
 main(int argc, char *argv[])
@@ -59,16 +57,15 @@ main(int argc, char *argv[])
 
 	filename = argv[1];
 	size = atoi(argv[2]);
-	byte = '@';
+	byte = '\n';
 
 	if (size == 0) {
 		err(1, "Sparse files of length zero are not meaningful");
 	}
 
-	tprintf("Creating a sparse file of size %d\n", size);
-	nprintf(".");
+	printf("Creating a sparse file of size %d\n", size);
 
-	fd = open(filename, O_RDWR|O_CREAT|O_TRUNC);
+	fd = open(filename, O_WRONLY|O_CREAT|O_TRUNC);
 	if (fd < 0) {
 		err(1, "%s: create", filename);
 	}
@@ -76,7 +73,6 @@ main(int argc, char *argv[])
 	if (lseek(fd, size-1, SEEK_SET) == -1) {
 		err(1, "%s: lseek", filename);
 	}
-	nprintf(".");
 	r = write(fd, &byte, 1);
 	if (r < 0) {
 		err(1, "%s: write", filename);
@@ -84,30 +80,8 @@ main(int argc, char *argv[])
 	else if (r != 1) {
 		errx(1, "%s: write: Unexpected result count %d", filename, r);
 	}
-	nprintf(".");
 
-	// Now check this byte.
-	// First seek to the beginning and then seek back to where the byte
-	// should be.
-	if(lseek(fd, 0, SEEK_SET) == -1) {
-		err(1, "lseek failed to seek to beginning of file\n");
-	}
-	nprintf(".");
-	// Now seek back to where the byte should be
-	// While at it, also test SEEK_CUR
-	if(lseek(fd, size-1, SEEK_CUR) == -1) {
-		err(1, "lseek failed to seek to %d of file\n", size-1);
-	}
-	nprintf(".");
-	char test;
-	r = read(fd, &test, 1);
-	if(test != byte) {
-		err(1, "Byte test failed. Expected (%c) != Observed (%c)\n", byte, test);
-	}
-	nprintf(".");
 	close(fd);
 
-	nprintf("\n");
-	success(TEST161_SUCCESS, SECRET, "/testbin/sparsefile");
 	return 0;
 }

userland/testbin/tictac/tictac.c

@@ -92,7 +92,7 @@ main(void)
 			win = do_move(player);
 			print_board();
 			if (win) {
-				tprintf("Player %d, you WON!\n\n", player);
+				printf("Player %d, you WON!\n\n", player);
 				break;		/* out of for loop */
 			}
 		}
@@ -101,7 +101,7 @@ main(void)
 		 * tie game.
 		 */
 		if (!win)
-			tprintf("Tie Game!\n\n");
+			printf("Tie Game!\n\n");
 		if (!ask_yesno("Do you wish to play again?"))
 			break;			/* out of while loop */
 	}
@@ -121,9 +121,9 @@ main(void)
 void
 print_instructions(void)
 {
-	tprintf("Welcome to tic-tac-toe!\n");
-	tprintf("Player 1 always plays X and player 2 always play O\n");
-	tprintf("Good luck!\n\n\n");
+	printf("Welcome to tic-tac-toe!\n");
+	printf("Player 1 always plays X and player 2 always play O\n");
+	printf("Good luck!\n\n\n");
 }
 
 void
@@ -142,22 +142,22 @@ print_board(void)
 	int i, j;
 
 	/* Print labels across the top */
-	tprintf("\n    0  1  2\n");
+	printf("\n    0  1  2\n");
 
 	for (i = 0; i < DIM; i++) {
 		/* Print row labels */
-		tprintf(" %d ", i);
+		printf(" %d ", i);
 		for (j = 0; j < DIM; j++) {
 			switch (board[i][j]) {
-				case EMPTY: tprintf("   "); break;
-				case X_MARKER: tprintf(" X "); break;
-				case O_MARKER: tprintf(" O "); break;
-				default: tprintf("???"); break;
+				case EMPTY: printf("   "); break;
+				case X_MARKER: printf(" X "); break;
+				case O_MARKER: printf(" O "); break;
+				default: printf("???"); break;
 			}
 		}
-		tprintf("\n");
+		printf("\n");
 	}
-	tprintf("\n");
+	printf("\n");
 }
 
 /*
@@ -181,7 +181,7 @@ ask_yesno(const char *msg)
 	char answer[MAXSTRING];
 
 	while (TRUE) {
-		tprintf("%s [yes/no] ", msg);
+		printf("%s [yes/no] ", msg);
 		if (read_string(answer, MAXSTRING) < 0)
 			return(FALSE);
 		if (Strcmp(answer, "yes"))
@@ -189,7 +189,7 @@ ask_yesno(const char *msg)
 		else if (Strcmp(answer, "no"))
 			return(FALSE);
 		else
-			tprintf("Please answer either yes or no\n");
+			printf("Please answer either yes or no\n");
 	}
 }
 
@@ -216,32 +216,32 @@ do_move(int player)
 	char answer[MAXSTRING];
 	char cx;
 
-	tprintf("Player %d (%c), your move\n", player,
+	printf("Player %d (%c), your move\n", player,
 	       player == X_PLAYER ? 'X' : 'O');
 
 	while (TRUE) {
-		tprintf("Which row [0-%d]: ", DIM-1);
+		printf("Which row [0-%d]: ", DIM-1);
 		if (read_string(answer, MAXSTRING) < 0)
 			return(FALSE);
 		cx = answer[0];
 		x = cx - '0';
 		if (x < 0 || x >= DIM) {
-			tprintf("Invalid row; must be >= 0 and < %d\n", DIM-1);
+			printf("Invalid row; must be >= 0 and < %d\n", DIM-1);
 			continue;
 		}
-		tprintf("Which column [0-%d]: ", DIM-1);
+		printf("Which column [0-%d]: ", DIM-1);
 		if (read_string(answer, MAXSTRING) < 0)
 			return(FALSE);
 		cx = answer[0];
 		y = cx - '0';
 		if (y < 0 || y >= DIM) {
-			tprintf("Invalid column; must be >= 0 and < %d\n",
+			printf("Invalid column; must be >= 0 and < %d\n",
 				DIM-1);
 			continue;
 		}
 
 		if (board[x][y] != EMPTY) {
-			tprintf("That location is occupied; please try again\n");
+			printf("That location is occupied; please try again\n");
 			print_board();
 		} else
 			break;

userland/testbin/userthreads/userthreads.c

@@ -79,7 +79,7 @@ main(int argc, char *argv[])
 	    threadfork(BladeRunner);
     }
 
-    tprintf("Parent has left.\n");
+    printf("Parent has left.\n");
     return 0;
 }
 
@@ -93,7 +93,7 @@ BladeRunner()
 {
     while (count < MAX) {
 	if (count % 500 == 0)
-	    tprintf("Blade ");
+	    printf("Blade ");
 	count++;
     }
 }
@@ -103,7 +103,7 @@ ThreadRunner()
 {
     while (count < MAX) {
 	if (count % 513 == 0)
-	    tprintf(" Runner\n");
+	    printf(" Runner\n");
 	count++;
     }
 }

userland/testbin/zero/zero.c

@@ -39,7 +39,6 @@
 #include <unistd.h>
 #include <errno.h>
 #include <err.h>
-#include <test161/test161.h>
 
 /*
  * Some initialized data. This is here to increase the chance that
@@ -79,7 +78,6 @@ check_data(void)
 	if (k != SUM_OF_DATA_STUFF) {
 		warnx("My initialized data sums to the wrong value!");
 		warnx("Got: %u  Expected: %u", k, SUM_OF_DATA_STUFF);
-		success(TEST161_FAIL, SECRET, "/testbin/zero");
 		errx(1, "FAILED");
 	}
 }
@@ -96,7 +94,6 @@ check_bss(void)
 			warnx("BSS entry at index %u (address %p) not zero!",
 			      i, &bss_stuff[i]);
 			warnx("Found: 0x%x", bss_stuff[i]);
-			success(TEST161_FAIL, SECRET, "/testbin/zero");
 			errx(1, "FAILED");
 		}
 	}
@@ -115,10 +112,9 @@ check_sbrk(void)
 	base = sbrk(SBRK_SIZE);
 	if (base == (void *)-1) {
 		if (errno == ENOSYS) {
-			tprintf("I guess you haven't implemented sbrk yet.\n");
+			printf("I guess you haven't implemented sbrk yet.\n");
 			return;
 		}
-		success(TEST161_FAIL, SECRET, "/testbin/zero");
 		err(1, "sbrk");
 	}
 
@@ -128,7 +124,6 @@ check_sbrk(void)
 			      i, &base[i]);
 			warnx("Got: 0x%x", (unsigned char)base[i]);
 			warnx("Base of sbrk region: %p", base);
-			success(TEST161_FAIL, SECRET, "/testbin/zero");
 			errx(1, "FAILED");
 		}
 	}
@@ -138,13 +133,13 @@ check_sbrk(void)
 int
 main(void)
 {
-	tprintf("zero: phase 1: checking .bss\n");
+	printf("zero: phase 1: checking .bss\n");
 	check_data();
 	check_bss();
 
-	tprintf("zero: phase 2: checking sbrk()\n");
+	printf("zero: phase 2: checking sbrk()\n");
 	check_sbrk();
 
-	success(TEST161_SUCCESS, SECRET, "/testbin/zero");
+	printf("zero: passed\n");
 	return 0;
 }