From ae1d34da2aa8fe4286b9e1770446fbea5ac96fe6 Mon Sep 17 00:00:00 2001
From: minhtrannhat <minh@minhtrannhat.com>
Date: Wed, 6 Dec 2023 23:03:36 -0500
Subject: [PATCH] feat(udp): unknown command completed

---
 src/myftp/client.py | 30 ++++++++++++++++++------------
 src/myftp/server.py |  9 ++++++++-
 2 files changed, 26 insertions(+), 13 deletions(-)

diff --git a/src/myftp/client.py b/src/myftp/client.py
index f47964c..1c155ae 100644
--- a/src/myftp/client.py
+++ b/src/myftp/client.py
@@ -24,6 +24,7 @@ get_request_opcode: int = 0b001
 change_request_opcode: int = 0b010
 summary_request_opcode: int = 0b011
 help_request_opcode: int = 0b100
+unknown_request_opcode: int = 0b101
 
 # Res-code dict
 rescode_dict: dict[int, str] = {
@@ -94,44 +95,49 @@ class Client:
 
                 # put command handling
                 elif put_command_pattern.match(command):
-                    _, filename = command.split(" ", 1)
+                    command_name, filename = command.split(" ", 1)
                     print(
                         f"myftp> - {self.protocol} - Putting file {filename} into the server"
                     ) if self.debug else None
 
                 # summary command handling
                 elif summary_command_pattern.match(command):
-                    _, filename = command.split(" ", 1)
+                    command_name, filename = command.split(" ", 1)
                     print(
                         f"myftp> - {self.protocol} - Summary file {filename} from the server"
                     ) if self.debug else None
 
                 # change command handling
                 elif change_command_pattern.match(command):
-                    _, old_filename, new_filename = command.split()
+                    command_name, old_filename, new_filename = command.split()
                     print(
                         f"myftp> - {self.protocol} - Changing file named {old_filename} into {new_filename} on the server"
                     ) if self.debug else None
 
+                # unknown request, assigned opcode is 0b101
                 else:
-                    print(
-                        f"myftp> - {self.protocol} - Invalid command. Supported commands are put, get, summary, change, list and help. Type help for detailed usage."
-                    )
-                    continue
+                    command_name = None
+                    first_byte: int = unknown_request_opcode << 5
 
                 # get or put case
                 if command_name == "get" or command_name == "put":
-                    payload = first_byte.to_bytes(1, "big") + second_byte_to_n_byte
+                    payload = first_byte.to_bytes(1, "big") + second_byte_to_n_byte  # type: ignore
 
-                # help case
+                elif command_name == "summary":
+                    pass
+
+                elif command == "change":
+                    pass
+
+                # help case and unknown request
                 else:
-                    payload: bytes = first_byte.to_bytes(1, "big")
+                    payload: bytes = first_byte.to_bytes(1, "big")  # type: ignore
 
                 print(
-                    f"myftp> - {self.protocol} - sent payload {bin(int.from_bytes(payload, byteorder='big'))[2:]} to the server"
+                    f"myftp> - {self.protocol} - sent payload {bin(int.from_bytes(payload, byteorder='big'))[2:]} to the server"  # type: ignore
                 ) if self.debug else None
 
-                client_socket.sendto(payload, (self.server_name, self.server_port))
+                client_socket.sendto(payload, (self.server_name, self.server_port))  # type: ignore
 
                 response_payload = client_socket.recv(2048)
 
diff --git a/src/myftp/server.py b/src/myftp/server.py
index 9110ae0..9acfd20 100644
--- a/src/myftp/server.py
+++ b/src/myftp/server.py
@@ -29,6 +29,7 @@ op_codes_dict: dict[int, str] = {
     0b010: "change",
     0b011: "summary",
     0b100: "help",
+    0b101: "unknown",
 }
 
 
@@ -103,6 +104,12 @@ class Server:
                         filename = None
                         response_data = None
 
+                elif request_type == "unknown":
+                    rescode = rescode_fail_dict["unknown_request_rescode"]
+                    filename_length = None
+                    filename = None
+                    response_data = None
+
                 res_payload: bytes = self.build_res_payload(
                     rescode=rescode,  # type: ignore
                     filename_length=filename_length,
@@ -143,7 +150,7 @@ class Server:
             )
 
         except KeyError:
-            raise KeyError("Can't find the request type of this payload")
+            raise KeyError("Cant not find the request type")
 
         return request_type, filename_length_in_bytes